Optimize ZonedDateTime.now().toInstant()#5303
Merged
Merged
Conversation
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes unnecessary ZonedDateTime allocations where only an Instant (or epoch millis) is required, and modernizes day-of-week formatting in a test.
Changes:
- Replace
ZonedDateTime.now().toInstant()withInstant.now()where only epoch millis are needed. - Replace legacy
Date/SimpleDateFormatusage withDateTimeFormatterin the day-of-week test setup. - Make locale handling for day-of-week uppercasing explicit.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| itests/org.openhab.core.automation.module.timer.tests/src/main/java/org/openhab/core/automation/module/timer/internal/DayOfWeekConditionHandlerTest.java | Switches to DateTimeFormatter for day-of-week derivation and removes legacy date APIs. |
| bundles/org.openhab.core/src/test/java/org/openhab/core/items/GenericItemTest.java | Uses Instant.now() for timestamp comparisons instead of creating ZonedDateTime instances. |
| bundles/org.openhab.core.io.rest.log/src/main/java/org/openhab/core/io/rest/log/internal/LogHandler.java | Uses Instant.now().toEpochMilli() for log timestamps instead of ZonedDateTime conversion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
holgerfriedrich
approved these changes
Jan 25, 2026
holgerfriedrich
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks.
Use of default locale is gone now, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a
ZonedDateTimejust to get itsInstantis unnecessary.