[DSL generator] Do not generate thing label if same as in thing type#5305
Merged
Merged
Conversation
Apply the same logic as for YAML. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Contributor
|
I'm not sure I agree with this. It's mixing up the properties of the two entities and it can make things confusing. |
Contributor
Author
|
If you load a thing without label, you expect the same when re-exporting it. |
Contributor
|
Bear with me a bit because I don't understand this. If the thing was without label, why would thing.getLabel() return anything but null? |
Contributor
Author
|
Because the default is to take the label in the thing type if not defined in the thing itself. This is like that probably since OH 2 (introduction of thing concept). |
Contributor
|
Thanks for the explanation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the same logic as for YAML.