io.rest.FileFormatResource: stream is already sorted - #5750
Open
dilyanpalauzov wants to merge 1 commit into
Open
io.rest.FileFormatResource: stream is already sorted#5750dilyanpalauzov wants to merge 1 commit into
dilyanpalauzov wants to merge 1 commit into
Conversation
lolodomo
approved these changes
Aug 8, 2026
lolodomo
left a comment
lolodomo
left a comment
Contributor
There was a problem hiding this comment.
That's correct.
Already sorted in groups when building it at line 1445.
wborn
requested changes
Aug 11, 2026
wborn
left a comment
wborn
left a comment
Member
There was a problem hiding this comment.
This review was performed by AI before manual maintainer review.
The code change looks correct. groups is already sorted by item name, and filtering that ordered list to obtain topGroups preserves the existing order, so the additional sort is redundant.
However, the commit is missing the required Signed-off-by line. The small patch exception only covers spelling/grammar fixes and single-line documentation changes, so it does not apply to this Java code change.
Please sign off the commit before this is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.