Persistence DSL validation - #5775
Open
mherwege wants to merge 1 commit into
Open
Conversation
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Contributor
|
Does this only apply to xtend, no other file based configuration (yaml)? |
Contributor
Author
There is no yaml configuration for persistence yet. The UI configuration should not be impacted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes openhab/openhab-addons#21351
When using a
filterorstrategyin a persistence configuration, that filter or strategy needs to be defined in theFiltersorStrategiessection (except for globally defined strategies).Failure to do so did not generate a parse exception, only manifested itself when trying to use the filter or strategy. This caused NPE's, because the name of the filter or strategy would be null in the half parsed object.
This validation makes sure filters and strategies are properly defined and rejects loading the
persistfile if not.It also checks for duplicate filter or strategy names, also so far not caught at parse time and potentially leading to unexpected behaviour.