OSGi-ify Graal nfi libffi#65
Conversation
Signed-off-by: Holger Hees <holger.hees@gmail.com>
|
@florian-h05 and @ccutrer can you please review? |
florian-h05
left a comment
florian-h05
left a comment
There was a problem hiding this comment.
I am no OSGi-ify maintainer, so I can’t merge.
| <artifactId>org.graalvm.truffle.truffle-nfi-libffi</artifactId> | ||
| <version>${graalvm.version}</version> | ||
|
|
||
| <name>GraalVM :: Truffle :: NFI :: LIBFFI</name> |
There was a problem hiding this comment.
| <name>GraalVM :: Truffle :: NFI :: LIBFFI</name> | |
| <name>GraalVM :: Truffle :: NFI :: LibFFI</name> |
Signed-off-by: Holger Hees <holger.hees@gmail.com>
holgerfriedrich
left a comment
holgerfriedrich
left a comment
There was a problem hiding this comment.
Thanks for the reviews, @florian-h05 and @ccutrer.
|
Oops. LibFFI acts as a TruffleLanguageProvider, so will need these lines added to the osgi.bnd file (like python-language): It will also need to be at start-level 78 when referenced from a feature.xml |
|
I did only check if the BND file looks good, not if it’s missing service loading … |
I'm not an osgi expert. So I would not see it also if I look into this file ;-) But I created a follow up pull request to take care of this |
4 participants
this lib was missing for cases where native modules where loaded