Skip to content

Items List: Add select all / deselect all #3144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Apr 9, 2025

No description provided.

@jimtng jimtng requested review from ghys and florian-h05 as code owners April 9, 2025 14:41
Copy link

relativeci bot commented Apr 9, 2025

#3016 Bundle Size — 11.17MiB (+0.01%).

2677d65(current) vs 9e3b377 main#3013(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#3016
     Baseline
#3013
No change  Initial JS 2.01MiB 2.01MiB
No change  Initial CSS 577.53KiB 577.53KiB
No change  Cache Invalidation 18.71% 18.71%
No change  Chunks 250 250
No change  Assets 273 273
No change  Modules 2974 2974
No change  Duplicate Modules 150 150
No change  Duplicate Code 1.71% 1.71%
No change  Packages 97 97
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#3016
     Baseline
#3013
Regression  JS 9.38MiB (+0.01%) 9.38MiB
No change  CSS 867.58KiB 867.58KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch jimtng:select-all-itemsProject dashboard


Generated by RelativeCIDocumentationReport issue

Signed-off-by: Jimmy Tanagra <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!
I have refactored the code to use computed data instead of methods, this is the cleaner way, and I fixed the problem that computed initially did not work.

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Apr 15, 2025
@florian-h05 florian-h05 added this to the 5.0 milestone Apr 15, 2025
@florian-h05 florian-h05 merged commit eaee49c into openhab:main Apr 15, 2025
5 checks passed
@jimtng jimtng deleted the select-all-items branch April 17, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants