-
-
Notifications
You must be signed in to change notification settings - Fork 272
Bump @vue/tsconfig from 0.7.0 to 0.8.1 in /bundles/org.openhab.ui/web in the vue-ecosystem group #3725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
#4311 Bundle Size — 12.71MiB (~+0.01%).1279148(current) vs 710f811 main#4299(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch dependabot/npm_and_yarn/bundles/... Project dashboard Generated by RelativeCI Documentation Report issue |
355664d to
b52a4c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the @vue/tsconfig package from version 0.7.0 to 0.8.1 in the Vue ecosystem dependencies. The update includes breaking changes from version 0.8.0 that enable stricter TypeScript checking options, though some of the most impactful changes (like exactOptionalPropertyTypes) were reverted in 0.8.1.
Changes:
- Updated
@vue/tsconfigdependency version in package.json - Updated corresponding package-lock.json with new version, resolved URL, and integrity hash
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| bundles/org.openhab.ui/web/package.json | Updated @vue/tsconfig from ^0.7.0 to ^0.8.1 in devDependencies |
| bundles/org.openhab.ui/web/package-lock.json | Updated package lock with new version 0.8.1, registry URL, and integrity hash |
Files not reviewed (1)
- bundles/org.openhab.ui/web/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@florian-h05 - I addressed the new typescript violations in this branch. Should I check that in as a new PR, or is this someway to merge with this one? |
|
You should be able to push to that branch here, and dependabot will stop updating that branch automatically then. |
05c7667 to
6af5f50
Compare
Signed-off-by: Jeff James <[email protected]>
9cb2683 to
6af5f50
Compare
|
@florian-h05 - could use your help on this one. It is failing the format check on the server, but passes fine locally. Not sure if this could be the same issue @mherwege is facing? [EDIT] you can ignore, it was a git issue on my part. |
6af5f50 to
82c5f94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 13 out of 15 changed files in this pull request and generated 4 comments.
Files not reviewed (1)
- bundles/org.openhab.ui/web/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| results.forEach((result, index) => { | ||
| const locale = localeFilesArray[index] | ||
| if (result.status === 'fulfilled') { | ||
| if (locale != undefined && result.status === 'fulfilled') { |
Copilot
AI
Jan 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use strict equality (!==) instead of loose inequality (!=) for consistency and to avoid potential type coercion issues.
| if (locale != undefined && result.status === 'fulfilled') { | |
| if (locale !== undefined && result.status === 'fulfilled') { |
| return ((this.items[0].label) ? this.items[0].label : this.items[0].name) + ' + ' + (this.items.length - 1) | ||
| const firstItem = this.items[0] | ||
| if (!firstItem) return 'Analyze' | ||
| if (this.items.length === 1) return (firstItem?.label) ? firstItem.label : firstItem.name |
Copilot
AI
Jan 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The optional chaining operator on firstItem?.label is redundant since firstItem is already checked for undefined on line 452. You can safely use firstItem.label instead.
| if (this.items.length === 1) return (firstItem?.label) ? firstItem.label : firstItem.name | |
| if (this.items.length === 1) return (firstItem.label) ? firstItem.label : firstItem.name |
| page () { | ||
| const chartPage = this.coordSystem.getChartPage(this.coordSettings, this.seriesOptions, this.items) | ||
| const coordSystem = this.coordSystem | ||
| if(!coordSystem) { |
Copilot
AI
Jan 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space after the if keyword. Should be if (!coordSystem) for consistency with project style.
| if(!coordSystem) { | |
| if (!coordSystem) { |
| } | ||
| this.coordSystem.initAxes(this.coordSettings) | ||
| const coordSystem = this.coordSystem | ||
| if(!coordSystem) { |
Copilot
AI
Jan 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space after the if keyword. Should be if (!coordSystem) for consistency with project style.
| if(!coordSystem) { | |
| if (!coordSystem) { |
Signed-off-by: Jeff James <[email protected]>
|
@florian-h05 - given i made code changes here, you should review. Most of the new typescript violations were due to the possibility of "undefined" being returned from a lookup in an object. |
Bumps the vue-ecosystem group in /bundles/org.openhab.ui/web with 1 update: @vue/tsconfig.
Updates
@vue/tsconfigfrom 0.7.0 to 0.8.1Release notes
Sourced from
@vue/tsconfig's releases.Commits
4a223b20.8.1a235c5ffix: disableexactOptionalPropertyTypesfor nowc2c92d60.8.04f1e64aci: use trusted publisher for npm publishe690a76feat!: enablenoUncheckedIndexedAccessandexactOptionalPropertyTypes(#36)85a620afeat!: disablelibReplacementfor better performance (#35)b22acb3docs: explain the options in tsconfig.lib.json1334411docs: Bump up the requred Vue.js version to>= 3.4in README (#34)1a34344chore: use lowercasebundlerformoduleResolution29acc1adocs: be specific about what kind of unwanted types we're avoidingMaintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for
@vue/tsconfigsince your current version.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions