Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 6, 2026

Bumps the vue-ecosystem group in /bundles/org.openhab.ui/web with 1 update: @vue/tsconfig.

Updates @vue/tsconfig from 0.7.0 to 0.8.1

Release notes

Sourced from @​vue/tsconfig's releases.

v0.8.1

fix: do not turn on exactOptionalPropertyTypes for now [a235c5f]

Full Changelog: vuejs/tsconfig@v0.8.0...v0.8.1

v0.8.0

Breaking Changes


If you experience a significant number of type errors in your projects after upgrading to this version, you might want to consider a gradual approach to adopting the new options:

  • After upgrading to @vue/tsconfig, use supress-ts-errors (npx suppress-ts-errors && npx suppress-ts-errors vue src/**/*.vue) to insert @ts-expect-error comments in your current codebase.
  • This way, the stricter configuration will only apply to any new code you add, allowing you to address the existing errors later when you have more time.

Full Changelog: vuejs/tsconfig@v0.7.0...v0.8.0

Commits
  • 4a223b2 0.8.1
  • a235c5f fix: disable exactOptionalPropertyTypes for now
  • c2c92d6 0.8.0
  • 4f1e64a ci: use trusted publisher for npm publish
  • e690a76 feat!: enable noUncheckedIndexedAccess and exactOptionalPropertyTypes (#36)
  • 85a620a feat!: disable libReplacement for better performance (#35)
  • b22acb3 docs: explain the options in tsconfig.lib.json
  • 1334411 docs: Bump up the requred Vue.js version to >= 3.4 in README (#34)
  • 1a34344 chore: use lowercase bundler for moduleResolution
  • 29acc1a docs: be specific about what kind of unwanted types we're avoiding
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for @​vue/tsconfig since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file main ui Main UI labels Jan 6, 2026
@dependabot dependabot bot added main ui Main UI dependencies Pull requests that update a dependency file labels Jan 6, 2026
@relativeci
Copy link

relativeci bot commented Jan 6, 2026

#4311 Bundle Size — 12.71MiB (~+0.01%).

1279148(current) vs 710f811 main#4299(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
#4311
     Baseline
#4299
Regression  Initial JS 1.55MiB(~+0.01%) 1.55MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 6.95% 6.95%
No change  Chunks 614 614
No change  Assets 695 695
No change  Modules 2435 2435
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 128 128
No change  Duplicate Packages 1 1
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#4311
     Baseline
#4299
Regression  JS 11.01MiB (~+0.01%) 11.01MiB
No change  CSS 876.4KiB 876.4KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 45.73KiB 45.73KiB
No change  Other 847B 847B

Bundle analysis reportBranch dependabot/npm_and_yarn/bundles/...Project dashboard


Generated by RelativeCIDocumentationReport issue

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/bundles/org.openhab.ui/web/vue-ecosystem-ed1bbf7416 branch 3 times, most recently from 355664d to b52a4c5 Compare January 9, 2026 17:09
@jsjames jsjames requested a review from Copilot January 11, 2026 03:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the @vue/tsconfig package from version 0.7.0 to 0.8.1 in the Vue ecosystem dependencies. The update includes breaking changes from version 0.8.0 that enable stricter TypeScript checking options, though some of the most impactful changes (like exactOptionalPropertyTypes) were reverted in 0.8.1.

Changes:

  • Updated @vue/tsconfig dependency version in package.json
  • Updated corresponding package-lock.json with new version, resolved URL, and integrity hash

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
bundles/org.openhab.ui/web/package.json Updated @vue/tsconfig from ^0.7.0 to ^0.8.1 in devDependencies
bundles/org.openhab.ui/web/package-lock.json Updated package lock with new version 0.8.1, registry URL, and integrity hash
Files not reviewed (1)
  • bundles/org.openhab.ui/web/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jsjames
Copy link
Contributor

jsjames commented Jan 11, 2026

@florian-h05 - I addressed the new typescript violations in this branch. Should I check that in as a new PR, or is this someway to merge with this one?

https://github.com/jsjames/openhab-webui/tree/dependabot/npm_and_yarn/bundles/org.openhab.ui/web/vue-ecosystem-ed1bbf7416

@florian-h05
Copy link
Contributor

You should be able to push to that branch here, and dependabot will stop updating that branch automatically then.

@jsjames jsjames force-pushed the dependabot/npm_and_yarn/bundles/org.openhab.ui/web/vue-ecosystem-ed1bbf7416 branch from 05c7667 to 6af5f50 Compare January 12, 2026 18:00
Signed-off-by: Jeff James <[email protected]>
@jsjames jsjames force-pushed the dependabot/npm_and_yarn/bundles/org.openhab.ui/web/vue-ecosystem-ed1bbf7416 branch 2 times, most recently from 9cb2683 to 6af5f50 Compare January 12, 2026 19:05
@jsjames
Copy link
Contributor

jsjames commented Jan 12, 2026

@florian-h05 - could use your help on this one. It is failing the format check on the server, but passes fine locally. Not sure if this could be the same issue @mherwege is facing?

[EDIT] you can ignore, it was a git issue on my part.

@jsjames jsjames force-pushed the dependabot/npm_and_yarn/bundles/org.openhab.ui/web/vue-ecosystem-ed1bbf7416 branch from 6af5f50 to 82c5f94 Compare January 12, 2026 20:28
@jsjames jsjames requested a review from Copilot January 12, 2026 20:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 15 changed files in this pull request and generated 4 comments.

Files not reviewed (1)
  • bundles/org.openhab.ui/web/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

results.forEach((result, index) => {
const locale = localeFilesArray[index]
if (result.status === 'fulfilled') {
if (locale != undefined && result.status === 'fulfilled') {
Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use strict equality (!==) instead of loose inequality (!=) for consistency and to avoid potential type coercion issues.

Suggested change
if (locale != undefined && result.status === 'fulfilled') {
if (locale !== undefined && result.status === 'fulfilled') {

Copilot uses AI. Check for mistakes.
return ((this.items[0].label) ? this.items[0].label : this.items[0].name) + ' + ' + (this.items.length - 1)
const firstItem = this.items[0]
if (!firstItem) return 'Analyze'
if (this.items.length === 1) return (firstItem?.label) ? firstItem.label : firstItem.name
Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The optional chaining operator on firstItem?.label is redundant since firstItem is already checked for undefined on line 452. You can safely use firstItem.label instead.

Suggested change
if (this.items.length === 1) return (firstItem?.label) ? firstItem.label : firstItem.name
if (this.items.length === 1) return (firstItem.label) ? firstItem.label : firstItem.name

Copilot uses AI. Check for mistakes.
page () {
const chartPage = this.coordSystem.getChartPage(this.coordSettings, this.seriesOptions, this.items)
const coordSystem = this.coordSystem
if(!coordSystem) {
Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after the if keyword. Should be if (!coordSystem) for consistency with project style.

Suggested change
if(!coordSystem) {
if (!coordSystem) {

Copilot uses AI. Check for mistakes.
}
this.coordSystem.initAxes(this.coordSettings)
const coordSystem = this.coordSystem
if(!coordSystem) {
Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after the if keyword. Should be if (!coordSystem) for consistency with project style.

Suggested change
if(!coordSystem) {
if (!coordSystem) {

Copilot uses AI. Check for mistakes.
Signed-off-by: Jeff James <[email protected]>
@jsjames
Copy link
Contributor

jsjames commented Jan 12, 2026

@florian-h05 - given i made code changes here, you should review. Most of the new typescript violations were due to the possibility of "undefined" being returned from a lookup in an object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file main ui Main UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants