Things list: Add dynamic blue dot to status badges if status detail is set#4069
Things list: Add dynamic blue dot to status badges if status detail is set#4069florian-h05 merged 20 commits intoopenhab:mainfrom
Conversation
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
#5307 Bundle Size — 13.84MiB (~+0.01%).85c658e(current) vs b84ffb9 main#5280(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #5307 |
Baseline #5280 |
|
|---|---|---|
1.41MiB |
1.41MiB |
|
0B |
0B |
|
16.18% |
16.18% |
|
697 |
697 |
|
816 |
816 |
|
2817 |
2817 |
|
0 |
0 |
|
0% |
0% |
|
126 |
126 |
|
1 |
1 |
Bundle size by type
2 changes
2 regressions
| Current #5307 |
Baseline #5280 |
|
|---|---|---|
11.53MiB (~+0.01%) |
11.53MiB |
|
901.98KiB (+0.03%) |
901.7KiB |
|
638.41KiB |
638.41KiB |
|
526.1KiB |
526.1KiB |
|
295.6KiB |
295.6KiB |
|
847B |
847B |
Bundle analysis report Branch andrewfg:thing-info-badge Project dashboard
Generated by RelativeCI Documentation Report issue
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
|
Why not just render the description directly, instead of putting the description in a tooltip? |
The text may be quite long. So on the Things list page we show a badge. Whereas on the Thing detail page the text is shown in full. Also the idea is that the text may be dynamically added or removed so the badge is only displayed when there is something special to say. For example it can display a badge when there is a software update available, and no badge when there is not. In other words the badge only shows when something new has happened. Rather like the blue dot your inbox when there is mail. Or the blue dot on an app on your phone when it has an update. Or when a device has a low battery, etc. EDIT: I added some sample code for setting and removing the badge in the top post above. |
I agree this is a valid point of view. |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05
left a comment
There was a problem hiding this comment.
LGTM, thanks!
I've changed the intendation of the new styling to ensure it is encapsulated inside .things-list.
The purpose of this PR is to allow a dynamic information badge ("blue dot") to be applied to Things in the overview page in order to mark when the Thing has a special status. For example "low battery" or "firmware update available".
Resolves #4063
When a Thing's
statusInfo.status === 'ONLINE'and itsstatusInfo.description is not emptythen this PR adds a "blue dot" information badge to the overview list as shown in the screenshot below.Example code for setting and removing the badge
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch