Skip to content

Fix misaligned hypervisor load/store exception cause (#3146, #3147) #3153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ydinkin wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix misaligned hypervisor load/store exception cause (#3146, #3147) #3153

ydinkin wants to merge 3 commits into from
+409 −2

Conversation

@ydinkin
Copy link

@ydinkin ydinkin commented Dec 1, 2025

No description provided.

@ydinkin ydinkin marked this pull request as ready for review December 1, 2025 23:52
@JeanRochCoulon
Copy link
Contributor

JeanRochCoulon commented Dec 2, 2025

I cannot merge if the PR is not rebased. Can you rebase ?

@ydinkin ydinkin force-pushed the hsv_hlv_scause_fix branch from f9551fb to 9ac7d44 Compare December 2, 2025 13:58
@ydinkin
Copy link
Author

ydinkin commented Dec 2, 2025

I cannot merge if the PR is not rebased. Can you rebase ?

@JeanRochCoulon I rebased, but now the formatter returns 403 for some reason. Is that related to my changes?

@JeanRochCoulon
Copy link
Contributor

JeanRochCoulon commented Dec 2, 2025

We must run the following command to format the RTL
verible-verilog-format --inplace $(git ls-tree -r HEAD --name-only core |grep '.sv$' |grep -v '^core/include/std_cache_pkg.sv$' |grep -v cvfpu)

@ydinkin ydinkin force-pushed the hsv_hlv_scause_fix branch 2 times, most recently from 5068622 to 14c47c6 Compare December 7, 2025 15:27
@JeanRochCoulon
Copy link
Contributor

JeanRochCoulon commented Dec 9, 2025

Thanks for your contribution. Associated tests are appreciated.
Can you rebase ?

@ydinkin
Fix misaligned hypervisor load/store exception cause (openhwgroup#3146,
a0bd572 
openhwgroup#3147)

Remove the lsu_req_i gate so LSU-reported misaligned accesses always
propagate, covering hypervisor loads/stores that bypass translation and
were changing the exception cause (issues openhwgroup#3146, openhwgroup#3147).
@ydinkin
Add HSV misaligned store regression (openhwgroup#3147)
d4f96d6 
Add an hsv.d regression test to reproduce the incorrect
misaligned store exception cause from issue openhwgroup#3147.
@ydinkin
Add HLV misaligned load regression (openhwgroup#3146)
47e2925 
Add an hlv.d regression test to reproduce the incorrect
misaligned load exception cause from issue openhwgroup#3146.
@ydinkin
Copy link
Author

ydinkin commented Dec 10, 2025

Thanks for your contribution. Associated tests are appreciated. Can you rebase ?

Thanks, rebased :)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2026

👋 Hi there!

This pull request seems inactive. Need more help or have updates? Feel free to let us know. If there are no updates within the next few days, we'll go ahead and close this PR. 😊

@github-actions github-actions bot added the Status:Stale Issue or PR is stale and hasn't received any updates. label Jan 10, 2026
@JeanRochCoulon JeanRochCoulon removed the Status:Stale Issue or PR is stale and hasn't received any updates. label Jan 13, 2026
@JeanRochCoulon
Copy link
Contributor

JeanRochCoulon commented Jan 29, 2026

Sorry for the delay, can you rebase (again) or give me the right to write your branch ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeanRochCoulon JeanRochCoulon Awaiting requested review from JeanRochCoulon JeanRochCoulon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ydinkin @JeanRochCoulon