Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,14 @@ jobs:
- name: Run Tests
run: |
set -x
mkdir -p "verif/sim/out_$(date +%F)"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this folder created during the bash script? Do we need to add this line?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured that since we're forcing the dumping of artifacts, it would be safer if the CI could dump something even if the directory is empty. But if you think it useless I'm good to go delete it.

export RISCV=$(pwd)/tools/riscv-toolchain/
source ci/install-prereq.sh
source verif/sim/setup-env.sh
DV_SIMULATORS=${{matrix.simulator}},spike DV_TARGET=${{matrix.config}} bash verif/regress/${{matrix.testcase}}.sh

- name: Upload Lint Report to Github
if: always()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned that you are using this in your own fork so I will not double-check that this is the correct way to proceed ;)

uses: actions/upload-artifact@v4
with:
name: ${{matrix.simulator}}.${{matrix.testcase}}.${{matrix.config}}
Expand Down Expand Up @@ -181,12 +183,14 @@ jobs:
- name: Run Tests
run: |
set -x
mkdir -p "verif/sim/out_$(date +%F)"
export RISCV=$(pwd)/tools/riscv-toolchain/
source ci/install-prereq.sh
source verif/sim/setup-env.sh
DV_SIMULATORS=${{matrix.simulator}},spike DV_TARGET=${{matrix.config}} bash verif/regress/${{matrix.testcase}}.sh

- name: Upload Lint Report to Github
if: always()
uses: actions/upload-artifact@v4
with:
name: ${{matrix.simulator}}.${{matrix.testcase}}.${{matrix.config}}
Expand Down
Loading