Skip to content

Fix buildroot when launched from install script#1229

Merged
davidharrishmc merged 3 commits intoopenhwgroup:mainfrom
jordancarlin:linux-install
Jan 30, 2025
Merged

Fix buildroot when launched from install script#1229
davidharrishmc merged 3 commits intoopenhwgroup:mainfrom
jordancarlin:linux-install

Conversation

@jordancarlin
Copy link
Member

Generating buildroot worked when the makefile was launched directly but not when the install script called it. The issue was that $WALLY was not set.

@jordancarlin jordancarlin marked this pull request as draft January 13, 2025 08:12
@jordancarlin
Copy link
Member Author

Hmm. Seems like the updated version of buildroot doesn't like being built as root, which happens when running the install script. The problem seems to be specific to building tar.

@davidharrishmc
Copy link
Contributor

Don't love a configuration option called
FORCE_UNSAFE_CONFIGURE

Are there any alternatives?

@jordancarlin
Copy link
Member Author

Not a fan of it either. It's what the error message mentioned, so I'm testing it as a starting point to see if it actually fixes the problem. Will see how it goes in the CI and then investigate other options. There was nothing immediately apparent though.

@jordancarlin
Copy link
Member Author

Seems like with the new version of OpenSBI we need 1600000 instructions get to the OpenSBI banner instead of the previous 1400000. Updated regression-wally accordingly.

@jordancarlin
Copy link
Member Author

Looks like this did work to successfully install buildroot on all distros. I don't love needing to pass that configuration flag, but unfortunately I can't really think of a better option.

@jordancarlin jordancarlin marked this pull request as ready for review January 17, 2025 06:15
@jordancarlin jordancarlin marked this pull request as draft January 23, 2025 08:48
@jordancarlin jordancarlin marked this pull request as ready for review January 30, 2025 17:36
@jordancarlin
Copy link
Member Author

@davidharrishmc I still don't love the FORCE_UNSAFE_CONFIGURE, but I don't see another way to allow it to compile as root. While compiling as root generally isn't great, it is what we have been doing since even before I started overhauling the installation process and I don't see a way around it without making the script much more annoying to run.

@davidharrishmc davidharrishmc merged commit dea61fb into openhwgroup:main Jan 30, 2025
1 check passed
@jordancarlin jordancarlin mentioned this pull request Jan 30, 2025
@jordancarlin jordancarlin deleted the linux-install branch February 19, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants