change direct_post to direct_post.jwt #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
requested review from
awoie,
bc-pi,
c2bo,
danielfett,
jogu,
paulbastian,
selfissued,
tlodderstedt and
tplooker
bc-pi
reviewed
Nov 20, 2024
openid4vc-high-assurance-interoperability-profile-sd-jwt-vc-1_0.md
Outdated
Show resolved
Hide resolved
jogu
approved these changes
Nov 28, 2024
Co-authored-by: Joseph Heenan <[email protected]>
c2bo
approved these changes
Dec 2, 2024
Member
c2bo
left a comment
c2bo
left a comment
There was a problem hiding this comment.
I am wondering if we should remove the remark for Section 12.4? Section 12.4 is linked to within 7.2 and I am not sure we gain any real value from an informative mention in HAIP?
awoie
approved these changes
Dec 2, 2024
bc-pi
approved these changes
Dec 2, 2024
Contributor
Author
@c2bo can you please quote the text you mean? I will merge this and we can do a new PR if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #116