Skip to content

fix cmake 3.5 issue #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
domibel wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix cmake 3.5 issue #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c21528b
Update cmake.yml
leochan2009 May 6, 2025
5cbacd4
fix cmake 3.5 issue
domibel May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-20.04, ubuntu-22.04, macos-latest]
os: [macos-latest, ubuntu-24.04, ubuntu-22.04]

steps:
- uses: actions/checkout@v2

- name: Configure CMake
# Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.
# See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DOpenIGTLink_PROTOCOL_VERSION_3=ON -DOpenIGTLink_SUPERBUILD=OFF -DOpenIGTLink_USE_VP9=ON -DBUILD_TESTING=ON
run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DOpenIGTLink_PROTOCOL_VERSION_3=ON -DOpenIGTLink_SUPERBUILD=OFF -DOpenIGTLink_USE_VP9=OFF -DBUILD_TESTING=ON

- name: Build
# Build your program with the given configuration
Expand Down Expand Up @@ -60,7 +60,7 @@ jobs:
- name: Configure CMake
# Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.
# See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
run: cmake -B ${{github.workspace}}/SuperBuildTest -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DOpenIGTLink_PROTOCOL_VERSION_3=ON -DOpenIGTLink_SUPERBUILD=ON -DOpenIGTLink_USE_VP9=ON -DBUILD_TESTING=ON
run: cmake -B ${{github.workspace}}/SuperBuildTest -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DOpenIGTLink_PROTOCOL_VERSION_3=ON -DOpenIGTLink_SUPERBUILD=ON -DOpenIGTLink_USE_VP9=OFF -DBUILD_TESTING=ON

- name: Build
# Build your program with the given configuration
Expand Down
1 change: 0 additions & 1 deletion OpenIGTLinkConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,3 @@ SET(OpenIGTLink_LIBRARIES OpenIGTLink)

# The OpenIGTLink library targets.
SET(OpenIGTLink_LIBRARY_TARGETS_FILE "@OpenIGTLink_LIBRARY_TARGETS_FILE@")
include(${OpenIGTLink_LIBRARY_TARGETS_FILE})
3 changes: 1 addition & 2 deletions Testing/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
PROJECT( OpenIGTLinkTesting )

cmake_minimum_required(VERSION 2.8.11)
cmake_minimum_required(VERSION 3.5)
find_package(OpenIGTLink REQUIRED)
include(${OpenIGTLink_USE_FILE})
include_directories(${OpenIGTLink_INCLUDE_DIRS})
link_directories(${OpenIGTLink_LIBRARY_DIRS})
include_directories(${PROJECT_BINARY_DIR})
Expand Down