Omni support #106
Open
Omni support #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamrankin
reviewed
Nov 26, 2020
| const std::string deviceType = modifiedDevice->GetDeviceType(); | ||
| const std::string deviceName = modifiedDevice->GetDeviceName(); | ||
|
|
||
| std::cout << deviceType << std::endl; |
Contributor
There was a problem hiding this comment.
Please remove all print statements
adamrankin
reviewed
Nov 26, 2020
| } | ||
| else if (strcmp(deviceType.c_str(), "NDARRAY") == 0) | ||
| { | ||
| std::cout << "Device type is nd array" << std::endl; |
Contributor
There was a problem hiding this comment.
Please remove commented lines and re-indent to 2 spaces
adamrankin
reviewed
Nov 26, 2020
| { | ||
| return (this->Internal->IOConnector->GetCheckCRC() != 0); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Please restore the newline at the end of the file
Contributor
|
I can help with the cleanup, but I would need to confirm first that everything is working as is. For that I would need the latest OpenGITLinkIO changes as well, and it seems that those are not the latest. So, I'll get back to this after OpenIGTLinkIO is good. |
…dency This commit adds VTK as dependency when the OpenIGTLinkIO external project is built in a Slicer custom application. Co-authored-by: Sam Horvath <[email protected]>
…essage (openigtlink#107) * ENH: Ensure correct spacing, origin, and directions when receiving an igtl Image message
…ode name. this is more robust against any user modification of node names
…if, rename of nodes needs to be determined by the query type instead of volume type.
Some extensions still used the RegisterIncomingMRMLNode(vtkMRMLNode*) signature. Restored so that those extensions can keep working.
Previously nodes were created directly by calling New, which circumvented the default parameters specified by the scene. Fixed by calling mrmlScene->CreateNodeByClass() instead of creating a node with New().
When a Python package was installed on the (Windows) machine, then configuration of OpenIGTLinkIO failed due to incorrect (or even after uninstalling the other Python, undefined) Python3_EXECUTABLE variable.
… change. Got rid of extra empty lines, print statements and comments too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added function in OpenIGTLinkIF -> MRML -> vtkMRMLConnectorNode to add NDArray messages to a table node in slicer.