Open
Conversation
Member
|
the full init from claim admin seems wrong, this should be manage by a migration and fully removed I believe it was there for when legacy was running in // with modular |
|
@delcroip Good point. @Blue-B-code The initialization from claimAdmin was originally introduced to support the legacy + modular system running in parallel. Since we are no longer relying on the legacy model, it would be cleaner to migrate the remaining data and remove this fallback logic entirely instead of maintaining it in mapQueriesUserToStore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially, an Admin user was assigned a health facility. We removed it and saved the changes. The success message appears on the sidebar, but when refreshing the page or returning to it, the health facility is still there.
This happens because the mapQueriesUserToStore function forces user.healthFacilities to take the value of the old user.claimAdmin.healthFacilities when user.healthFacilities is null.
We prevented this to fix the issue.