fix(msggateway): preserve client background status - #3766
Open
buvidk1234 wants to merge 1 commit into
Open
Conversation
buvidk1234
requested review from
FGadvancer,
skiffer-git and
withchao
as code owners
July 8, 2026 14:05
pull-request-size
Bot
added
the
size/XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🅰 Please add the issue ID after "Fixes #"
Fixes #
Summary
ResetClientreads the background status from the connection context, but then immediately overwrites it withfalse.This causes the handshake
isBackgroundvalue to be ignored. For example, an iOS client that connects while in background can be treated as foreground, sopushToUsermay attempt WebSocket online push instead of returning the iOS background push result.This change removes the forced reset and keeps the background status parsed from the handshake.