Skip to content

fix: bundle VC++ runtime DLLs for Windows converter builds #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cs50victor merged 1 commit into from
Feb 18, 2026
Merged

fix: bundle VC++ runtime DLLs for Windows converter builds #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,14 @@ jobs:
shell: pwsh
run: |
bun download-converter.js
curl -L -o vc_redist.x64.exe https://aka.ms/vs/17/release/vc_redist.x64.exe
Start-Process -FilePath .\vc_redist.x64.exe -ArgumentList '/install','/quiet','/norestart' -Wait
$dlls = Get-ChildItem "$env:SystemRoot\System32" -Include 'vcruntime140*.dll','msvcp140*.dll','concrt140.dll','vcomp140.dll' -Recurse
foreach ($dll in $dlls) {
Copy-Item $dll.FullName "converter\$($dll.Name)"
Write-Output "Bundled $($dll.Name) ($($dll.Length) bytes)"
}
Remove-Item vc_redist.x64.exe
bun scripts/build_allfontsgen.js
$env:FONT_DATA_DIR="assets/onlyoffice-fontdata"; bun ./scripts/generate_office_fonts.js

Expand Down
13 changes: 13 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,19 @@ jobs:
- name: Download converter
run: bun download-converter.js

- name: Bundle VC++ runtime DLLs (Windows)
if: runner.os == 'Windows'
shell: pwsh
run: |
curl -L -o vc_redist.x64.exe https://aka.ms/vs/17/release/vc_redist.x64.exe
Start-Process -FilePath .\vc_redist.x64.exe -ArgumentList '/install','/quiet','/norestart' -Wait
$dlls = Get-ChildItem "$env:SystemRoot\System32" -Include 'vcruntime140*.dll','msvcp140*.dll','concrt140.dll','vcomp140.dll' -Recurse
foreach ($dll in $dlls) {
Copy-Item $dll.FullName "converter\$($dll.Name)"
Write-Output "Bundled $($dll.Name) ($($dll.Length) bytes)"
}
Remove-Item vc_redist.x64.exe

- name: Build allfontsgen
run: bun scripts/build_allfontsgen.js

Expand Down
Loading