Several small fixes to respond() #1663
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing display_markdown_message import in respond.py
Added parentheses to fix two conditions that incorrectly triggered due to operator precedence: - API key handler triggered on any "api key" error, ignoring offline status - Rate limit handler triggered on any "insufficient_quota" error, not just RateLimitError exceptions
Replace `type(e) == litellm.exceptions.RateLimitError` with `isinstance(e, litellm.exceptions.RateLimitError)` for proper exception type checking. While technically different behavior (isinstance() supports inheritance while type() == requires exact match), isinstance() is the correct and more robust approach for exception handling. If litellm introduces subclasses of RateLimitError in the future, isinstance() will correctly catch them.
Replace `any([...])` with `any(...)` using a generator expression. This improves performance by enabling short-circuiting - any() will stop evaluating as soon as it finds a True value, rather than building the entire list first. This is more memory efficient and potentially faster, especially when the first item matches.
endolith
force-pushed
the
display_markdown_message_is_not_defined
branch
from
de544f8 to
38b04df
Compare
endolith
changed the title
The comment describes removing highlighting when code execution finishes. The codebase consistently uses "highlight" terminology (highlight_active_line setting, "highlight the active line" in docs). "unlightlight" is not used elsewhere and appears to be a typo for "unhighlight".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing display_markdown_message import in respond.py
and fix missing parentheses in conditionals
(and then some other changes, each of which should be pretty easy to approve)
Describe the changes you have made:
Reference any relevant issues (e.g. "Fixes #000"):
Pre-Submission Checklist (optional but appreciated):
docs/CONTRIBUTING.mddocs/ROADMAP.mdOS Tests (optional but appreciated):