Skip to content

8379503: Intern constant expression of type String#978

Draft
mabbay wants to merge 14 commits intoopenjdk:code-reflectionfrom
mabbay:intern-string-constant-expr
Draft

8379503: Intern constant expression of type String#978
mabbay wants to merge 14 commits intoopenjdk:code-reflectionfrom
mabbay:intern-string-constant-expr

Conversation

@mabbay
Copy link
Copy Markdown
Member

@mabbay mabbay commented Mar 24, 2026

Explicitly intern the result of operation that model constant expression of type String, before interpretation and before bytecode generation. Not all cases are handled, because of the limitation we have in operation evaluation API.
A more general approach is to implement constant folding.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8379503: Intern constant expression of type String (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/978/head:pull/978
$ git checkout pull/978

Update a local copy of the PR:
$ git checkout pull/978
$ git pull https://git.openjdk.org/babylon.git pull/978/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 978

View PR using the GUI difftool:
$ git pr show -t 978

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/978.diff

@mabbay mabbay requested a review from PaulSandoz March 24, 2026 21:42
@mabbay mabbay self-assigned this Mar 24, 2026
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 24, 2026

👋 Welcome back mabbay! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 24, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@mabbay mabbay changed the title Intern constant expression of type String 8379503: Intern constant expression of type String Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant