os::get_process_uid and os::rss for BSD by snake66 · Pull Request #11 · openjdk/bsd-port

snake66 · 2026-06-18T11:46:20Z

Port of os::get_process_uid() and os::rss() to BSD.

Also makes sure relevant platform dependent includes are only included where supported.

This work is sponsored by The FreeBSD Foundation

I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

Progress

Change must not contain extraneous whitespace
Change must be properly reviewed (2 reviews required, with at least 1 Committer, 1 Author)

Reviewers

Kurt Miller (@bsdkurt - Committer)
Thomas Stuefe (@tstuefe - no project role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/bsd-port.git pull/11/head:pull/11
$ git checkout pull/11

Update a local copy of the PR:
$ git checkout pull/11
$ git pull https://git.openjdk.org/bsd-port.git pull/11/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11

View PR using the GUI difftool:
$ git pr show -t 11

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/bsd-port/pull/11.diff

Using Webrev

Link to Webrev Comment

This work is sponsored by The FreeBSD Foundation Co-authored-by: Kurt Miller <bsdkurt@gmail.com> Co-authored-by: Greg Lewis <glewis@eyesbeyond.com>

* Add BSD support for RSS process size. This probably needs a tweak for OpenBSD and NetBSD * Sync with Linux

bridgekeeper · 2026-06-18T11:47:06Z

👋 Welcome back haraldei! A progress list of the required criteria for merging this PR into bsd-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-06-18T11:48:20Z

@snake66 This change is no longer ready for integration - check the PR body for details.

mlbridge · 2026-06-18T11:51:46Z

Webrevs

This work is sponsored by The FreeBSD Foundation

bsdkurt

This approach seems like a reasonable way to support Apple/FreeBSD/OpenBSD/NetBSD in these functions. The alternative would be less readable.

bsdkurt · 2026-06-30T19:06:08Z

/reviewers 2

openjdk · 2026-06-30T19:07:05Z

@bsdkurt Only the author of the pull request or Reviewers are allowed to change the number of required reviewers.

bsdkurt · 2026-06-30T19:12:55Z

@snake66 Harald, could you bump the reviewers to 2? We want an Oracle dev to review as well and I guess as a committer, I can't issue the command.

snake66 · 2026-06-30T21:37:18Z

/reviewers 2

openjdk · 2026-06-30T21:39:21Z

@snake66
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Committer, 1 Author).

dholmes-ora · 2026-07-01T08:01:21Z

I'm afraid you are very unlikely to get an Oracle reviewer for this at this time.

snake66 · 2026-07-01T09:41:05Z

@dholmes-ora Ok, what do you suggest? Just wait for less busy times, or is there a fundamental problem?

tstuefe

Preface:

you really should consider splitting bsd from apple in hotspot
I'd consider adding utility features for BSD, eg BSD_ONLY/NOT_BSD (see examples in macros.hpp) and maybe also for the variants eg FREEBSD_ONLY/NOT_FREEBSD.

tstuefe · 2026-07-01T13:07:32Z

+#else
+  u_int namelen = 4;
+  int mib[4] = {CTL_KERN, KERN_PROC, KERN_PROC_PID, pid};
+#endif


Make namelen const, move it out of the ifdefs, and calculated it based on the array like this

const int namelen = sizeof(mib)/sizeof(mib[0]);

also mib can probably be constexpr as well.

Updated, but a few comments:

I could not use the NOT_FREEBSD() macro as it would require it to be a variadic macro. That works and is doable, but since the other similar macros are not variadic, I though it best to keep to the same pattern. Still reduced to a single conditional using plain #ifndef makes the code nicer I think.

mib can not be constexpr since it contains the pid which is by definition not const :)

haha right, sorry, my bad

tstuefe · 2026-07-01T13:07:51Z

+#else
+  pid_t pid = getpid();
+  struct KINFO_PROC_T kp;
+  size_t bufSize = sizeof kp;


we use brackets with sizeof

Fixed in latest commit.

tstuefe · 2026-07-01T13:14:09Z

+#define KI_RSS         p_vm_rssize
+#define KI_UID         p_uid
+#define KI_PID         p_pid
+#endif


This is an eyesore. Can this be shortened, and/or moved into a helper include?

dholmes-ora · 2026-07-02T06:14:38Z

@dholmes-ora Ok, what do you suggest? Just wait for less busy times, or is there a fundamental problem?

Less busy time may help (JEP-401 and JEP-539 are our priority on VM side right now) and we also have a lot of folk on summer vacations. Not many people with experience across different BSD flavors either (I don't have it).

snake66 · 2026-07-02T10:00:57Z

@tstuefe Thanks a lot for the feedback!

Preface:

you really should consider splitting bsd from apple in hotspot

That would be our preference too. But I think we need to have someone from the apple side join us in that effort.

From our perspective, I think it would be fine if everything that is under "bsd" now is renamed/moved to "macos" or something, and then we'll deal with the fallout on our side.

I'd consider adding utility features for BSD, eg BSD_ONLY/NOT_BSD (see examples in macros.hpp) and maybe also for the variants eg FREEBSD_ONLY/NOT_FREEBSD.

Yeah that's a good point. I'll see what that will do for the code.

snake66 · 2026-07-02T10:03:33Z

@dholmes-ora Yeah, I see those JEP's are quite involved, and touches a lot of code! And no worries, we'll wait for our time.

tstuefe · 2026-07-02T14:06:46Z

@tstuefe Thanks a lot for the feedback!

Preface:

you really should consider splitting bsd from apple in hotspot

That would be our preference too. But I think we need to have someone from the apple side join us in that effort.

Why? Just do it :-) The code for MacOS would not be affected, and we'd be less worried that a change in BSD accidentally breaks MacOS.

From our perspective, I think it would be fine if everything that is under "bsd" now is renamed/moved to "macos" or something, and then we'll deal with the fallout on our side.

Sure. os/macos would be the obvious choice.

snake66 · 2026-07-02T15:36:15Z

Why? Just do it :-)

Ok! I'll go for it, and see how it's received :)

Redused the amount of conditional sections to only concern the part of the mib that is different between the platforms. This work is sponsored by The FreeBSD Foundation

tstuefe

looks good to me

This work is sponsored by The FreeBSD Foundation

snake66 · 2026-07-03T14:38:41Z

Since I need one more review anyways, I thought I'd just as well submit another related refactoring to these functions.

snake66 · 2026-07-03T18:06:47Z

That didn't seem too successfull... I'll have a look at it tomorrow.

This work is sponsored by The FreeBSD Foundation

bsdkurt

LGTM

bridgekeeper · 2026-08-10T13:31:01Z

@snake66 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

snake66 and others added 3 commits June 18, 2026 13:16

Only macOS needs to include mach.h

56e6475

This work is sponsored by The FreeBSD Foundation Co-authored-by: Kurt Miller <bsdkurt@gmail.com> Co-authored-by: Greg Lewis <glewis@eyesbeyond.com>

BSD support for RSS

9e7292f

* Add BSD support for RSS process size. This probably needs a tweak for OpenBSD and NetBSD * Sync with Linux

Fix os::Bsd::get_process_uid() for OpenBSD and NetBSD

d217060

openjdk Bot added the rfr Pull request is ready for review label Jun 18, 2026

Fix NULL -> nullptr in os_bsd.cpp

a87298d

This work is sponsored by The FreeBSD Foundation

bsdkurt approved these changes Jun 30, 2026

View reviewed changes

openjdk Bot added the ready Pull request is ready to be integrated label Jun 30, 2026

openjdk Bot removed the ready Pull request is ready to be integrated label Jun 30, 2026

tstuefe reviewed Jul 1, 2026

View reviewed changes

Update os::rss() impl for BSD from feedback

376cedf

Redused the amount of conditional sections to only concern the part of the mib that is different between the platforms. This work is sponsored by The FreeBSD Foundation

tstuefe approved these changes Jul 3, 2026

View reviewed changes

bsdkurt approved these changes Jul 3, 2026

View reviewed changes

Refactor common code to get proc_info on BSD

bd8bdcd

This work is sponsored by The FreeBSD Foundation

Fix silly mistakes

b3e450f

This work is sponsored by The FreeBSD Foundation

bsdkurt requested changes Jul 7, 2026

View reviewed changes

Comment thread src/hotspot/os/bsd/os_bsd.cpp

bsdkurt self-requested a review July 8, 2026 13:04

bsdkurt approved these changes Jul 8, 2026

View reviewed changes

snake66 requested a review from tstuefe July 10, 2026 06:11

tstuefe approved these changes Jul 13, 2026

View reviewed changes

Uh oh!

Conversation

snake66 commented Jun 18, 2026 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Reviewers

Reviewing

Uh oh!

bridgekeeper Bot commented Jun 18, 2026

Uh oh!

openjdk Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

bsdkurt left a comment

Choose a reason for hiding this comment

Uh oh!

bsdkurt commented Jun 30, 2026

Uh oh!

openjdk Bot commented Jun 30, 2026

Uh oh!

bsdkurt commented Jun 30, 2026

Uh oh!

snake66 commented Jun 30, 2026

Uh oh!

openjdk Bot commented Jun 30, 2026

Uh oh!

dholmes-ora commented Jul 1, 2026

Uh oh!

snake66 commented Jul 1, 2026

Uh oh!

tstuefe left a comment

Choose a reason for hiding this comment

Uh oh!

tstuefe Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

snake66 Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

tstuefe Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

tstuefe Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

snake66 Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

tstuefe Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

dholmes-ora commented Jul 2, 2026

Uh oh!

snake66 commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snake66 commented Jul 2, 2026

Uh oh!

tstuefe commented Jul 2, 2026

Uh oh!

snake66 commented Jul 2, 2026

Uh oh!

tstuefe left a comment

Choose a reason for hiding this comment

Uh oh!

snake66 commented Jul 3, 2026

Uh oh!

snake66 commented Jul 3, 2026

Uh oh!

Uh oh!

bsdkurt left a comment

Choose a reason for hiding this comment

Uh oh!

bridgekeeper Bot commented Aug 10, 2026

Uh oh!

Reviewers

snake66 commented Jun 18, 2026 •

edited by openjdk Bot

Loading

openjdk Bot commented Jun 18, 2026 •

edited

Loading

mlbridge Bot commented Jun 18, 2026 •

edited

Loading

snake66 commented Jul 2, 2026 •

edited

Loading