Add support for *BSD to makefiles by snake66 · Pull Request #6 · openjdk/bsd-port

snake66 · 2026-03-19T10:04:24Z

Updates the makefiles to set up for compilation and building for *BSD.
This is a cleaned up diff towards the existing BSD port from the
battleblow/jdk repository.

Some parts have been held back for later PRs, mainly because I expect
them to require more thorough review. (Some is also probably outdated,
and we'll go through those first.)

This work is sponsored by The FreeBSD Foundation.

Co-authored-by: @battleblow
Co-authored-by: @bsdkurt

Progress

Change must not contain extraneous whitespace
Change must be properly reviewed (1 review required, with at least 1 Committer)

Reviewers

Erik Joelsson (@erikj79 - no project role)
Kurt Miller (@bsdkurt - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/bsd-port.git pull/6/head:pull/6
$ git checkout pull/6

Update a local copy of the PR:
$ git checkout pull/6
$ git pull https://git.openjdk.org/bsd-port.git pull/6/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6

View PR using the GUI difftool:
$ git pr show -t 6

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/bsd-port/pull/6.diff

Using Webrev

Link to Webrev Comment

We're not supporting 32 bit x86 builds anyway, so we don't need this change. This work was sponsored by The FreeBSD Foundation

Updates the makefiles to set up for compilation and building for *BSD. This is a cleaned up diff towards the existing BSD port from the battleblow/jdk repository. Some parts have been held back for later PRs, mainly because I expect them to require more thorough review. (Some is also probably outdated, and we'll go through those first.) This work is sponsored by The FreeBSD Foundation. Co-authored-by: Greg Lewis <glewis@openjdk.org> Co-authored-by: Kurt Miller <bsdkurt@openjdk.org>

bridgekeeper · 2026-03-19T10:05:39Z

👋 Welcome back haraldei! A progress list of the required criteria for merging this PR into bsd-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-03-19T10:06:44Z

@snake66 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Add support for *BSD to makefiles

Reviewed-by: erikj, kurt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the bsd-port branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the bsd-port branch, type /integrate in a new comment.

mlbridge · 2026-03-19T10:11:23Z

Webrevs

erikj79 · 2026-03-20T13:39:33Z

make/common/native/Link.gmk

          endif
        endif
+        ifeq ($(OPENJDK_TARGET_OS_ENV), bsd.netbsd)
+          /usr/sbin/paxctl +m $$@


I don't know what this tool is, but in general we prefer looking up tools in configure and using them through a variable. This allows for a uniform way of overriding any tool at configure time.

Changed in latest patch by adding it to make/autoconf/basic_tools.m4, and use variable for access.

make/common/JdkNativeCompilation.gmk

erikj79 · 2026-03-20T13:49:01Z

make/modules/java.desktop/Lib.gmk

 include lib/ClientLibraries.gmk

 ifeq ($(call isTargetOs, aix), false)
+ifneq ($(OPENJDK_TARGET_OS_ENV), bsd.openbsd)


Use isTargetOsEnv?

Also please fix indentation of the block.

Changes in latest version of the patch.

erikj79 · 2026-03-20T14:24:54Z

make/modules/jdk.sctp/Java.gmk

  EXCLUDE_FILES += $(SCTP_IMPL_CLASSES)
 endif

+ifeq ($(OPENJDK_TARGET_OS_ENV), bsd.openbsd)


Use macro? Same below.

Changed in latest version of the patch.

erikj79 · 2026-03-20T14:26:24Z

make/modules/jdk.sctp/Lib.gmk

 ifeq ($(call isTargetOs, linux), true)
+  SCTP_SUPPORTED=true
+endif
+ifeq ($(OPENJDK_TARGET_OS_ENV), bsd.freebsd)


Could use $(call Or,...) to avoid duplication.

Changed in latest version of the patch.

erikj79 · 2026-03-20T14:26:39Z

make/test/JtregNativeJdk.gmk

+    BUILD_JDK_JTREG_LIBRARIES_JDK_LIBS_libInheritedChannel := java.base:libjava
+    BUILD_JDK_JTREG_EXECUTABLES_LIBS_exelauncher := -pthread
+  endif
+  ifeq ($(OPENJDK_TARGET_OS_ENV), bsd.openbsd)


Changed in latest version of the patch.

erikj79 · 2026-03-20T14:27:29Z

make/RunTestsPrebuilt.gmk

    OPENJDK_TARGET_OS := linux
  else ifeq ($(UNAME_OS), Darwin)
    OPENJDK_TARGET_OS := macosx
+  else ifneq ($(findstring BSD,$(UNAME_OS)),)


We prefer space after comma when possible. https://openjdk.org/groups/build/doc/code-conventions.html

I agree that's nicer. Changed in latest version of the patch.

erikj79 · 2026-03-25T14:17:58Z

make/modules/jdk.sctp/Lib.gmk

-  SCTP_SUPPORTED=true
-endif
-ifeq ($(OPENJDK_TARGET_OS_ENV), bsd.freebsd)
+ifeq ($(call Or $(call isTargetOs, linux) $(call isTargetOsEnv, bsd.freebsd)), true)


Missing comma after Or.

Good catch! Fixed now. Seemed to work without it too, but not sure why.
Looks like it's the first non-test use of this macro :)

snake66 · 2026-03-27T09:05:13Z

Thanks a lot for the reviews!

snake66 · 2026-03-27T09:06:01Z

/integrate

openjdk · 2026-03-27T09:07:16Z

Going to push as commit bb48416.

openjdk · 2026-03-27T09:07:24Z

@snake66 Pushed as commit bb48416.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

snake66 and others added 2 commits March 19, 2026 11:00

Remove renaming of x86 for BSD

8ee4b53

We're not supporting 32 bit x86 builds anyway, so we don't need this change. This work was sponsored by The FreeBSD Foundation

openjdk bot added the rfr Pull request is ready for review label Mar 19, 2026

bsdkurt mentioned this pull request Mar 19, 2026

Adjust FreeBSD Hsdis support to apply to *BSD. battleblow/jdk#44

Merged

Adjust FreeBSD Hsdis support to apply to *BSD.

c656d29

erikj79 reviewed Mar 20, 2026

View reviewed changes

Fix review comments

fbe4902

snake66 requested a review from erikj79 March 25, 2026 09:36

erikj79 reviewed Mar 25, 2026

View reviewed changes

Fix missing comma

58e9ab3

snake66 requested a review from erikj79 March 26, 2026 10:31

erikj79 approved these changes Mar 26, 2026

View reviewed changes

bsdkurt approved these changes Mar 27, 2026

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 27, 2026

openjdk bot added the integrated Pull request has been integrated label Mar 27, 2026

openjdk bot closed this Mar 27, 2026

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 27, 2026

Conversation

snake66 commented Mar 19, 2026 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Mar 19, 2026

Uh oh!

openjdk bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

snake66 commented Mar 27, 2026

Uh oh!

snake66 commented Mar 27, 2026

Uh oh!

openjdk bot commented Mar 27, 2026

Uh oh!

openjdk bot commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

snake66 commented Mar 19, 2026 •

edited by openjdk bot

Loading

openjdk bot commented Mar 19, 2026 •

edited

Loading

mlbridge bot commented Mar 19, 2026 •

edited

Loading