Skip to content

Conversation

@nizarbenalla
Copy link
Member

@nizarbenalla nizarbenalla commented Dec 21, 2025

The test no longer needs to be problem listed now that the symbol information has caught up and is up to date.
This PR has a dependency on #28944, I want them integrate them in order.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #28944 must be integrated first

Issue

  • JDK-8372801: tools/sincechecker/modules/java.base/JavaBaseCheckSince.java fails with JDK 27 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28945/head:pull/28945
$ git checkout pull/28945

Update a local copy of the PR:
$ git checkout pull/28945
$ git pull https://git.openjdk.org/jdk.git pull/28945/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28945

View PR using the GUI difftool:
$ git pr show -t 28945

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28945.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 21, 2025

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Dec 21, 2025

@nizarbenalla The following labels will be automatically applied to this pull request:

  • compiler
  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@nizarbenalla
Copy link
Member Author

/label add javadoc
/label add core-libs

@nizarbenalla
Copy link
Member Author

/label remove jmx
/label remove compiler
/label remove serviceability

@openjdk
Copy link

openjdk bot commented Dec 21, 2025

@nizarbenalla
The javadoc label was successfully added.

@openjdk
Copy link

openjdk bot commented Dec 21, 2025

@nizarbenalla
The core-libs label was successfully added.

@openjdk
Copy link

openjdk bot commented Dec 21, 2025

@nizarbenalla
The jmx label was successfully removed.

@openjdk
Copy link

openjdk bot commented Dec 21, 2025

@nizarbenalla
The compiler label was successfully removed.

@openjdk
Copy link

openjdk bot commented Dec 21, 2025

@nizarbenalla
The serviceability label was successfully removed.

@nizarbenalla nizarbenalla changed the base branch from master to pr/28944 December 21, 2025 14:48
@nizarbenalla nizarbenalla marked this pull request as ready for review December 21, 2025 14:48
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 21, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 21, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants