Skip to content

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Dec 23, 2025

This test makes assumptions about the C2 ideal graph which are not true for PPC64. We need to get tests green also in jdk26 where the new test has landed in the meantime, so simply disabling it for the platform.
Test improvements can be done later if needed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374195: TestReplaceNarrowPhiWithBottomPhi fails on ppc64 platforms in (fast)debug (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28964/head:pull/28964
$ git checkout pull/28964

Update a local copy of the PR:
$ git checkout pull/28964
$ git pull https://git.openjdk.org/jdk.git pull/28964/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28964

View PR using the GUI difftool:
$ git pr show -t 28964

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28964.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2025

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 23, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant