Skip to content

8374217: Remove IO.java test from AOT ProblemList #28967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
naotoj wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −6
Open

8374217: Remove IO.java test from AOT ProblemList #28967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions test/jdk/ProblemList-AotJdk.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ java/lang/module/ModuleDescriptorHashCodeTest.java 0000000 generic-
# parameters will always cause the class java/lang/invoke/MethodHandleStatics to be initialized
java/lang/invoke/DumpMethodHandleInternals.java 0000000 generic-all

# The test uses "--add-modules jdk.internal.le" during production.
# So the test is incompatible with AOT_JDK testing because because all runs must have consistent module options on the command line.
java/lang/IO/IO.java 0000000 generic-all

# This test checks for a warning message that's already printed by
# sun.util.locale.BaseLocale.<clinit> during the training run. Because BaseLocale is aot-initialized,
# this message will not be printed in the production run.
Expand Down
4 changes: 2 additions & 2 deletions test/jdk/java/lang/IO/IO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@

/*
* @test
* @bug 8305457 8342936 8351435 8344706 8361613
* @bug 8305457 8342936 8351435 8344706 8361613 8374217
Copy link
Member

@jaikiran jaikiran Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Naoto, the changes look OK to me. However, the guidelines of using @bug for tests https://openjdk.org/guide/#jtreg say:

These bug ids refer to product bugs for which a fix is verified by this test. JBS issues that track changes to the test itself are not listed here.

So I think we shouldn't add this bug id here.

* @summary java.lang.IO tests
* @library /test/lib
* @run junit IO
Expand Down Expand Up @@ -149,7 +149,7 @@ void main() {
}
""");
}
var pb = ProcessTools.createTestJavaProcessBuilder(file.toString());
var pb = ProcessTools.createTestJavaProcessBuilder("-Xlog:aot=off", "-Xlog:cds=off", file.toString());
OutputAnalyzer output = ProcessTools.executeProcess(pb);
assertEquals(0, output.getExitValue());
assertTrue(output.getStderr().isEmpty());
Expand Down