Skip to content

Conversation

@sspitsyn
Copy link
Contributor

@sspitsyn sspitsyn commented Dec 23, 2025

Please, review a jdk 26 backport. This pull request contains a clean backport of simple changeset f5249db from the openjdk/jdk repository.
This changeset was reviewed by Chris Plummer and Alex Menkov.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374233: Overloaded constructor MountUnmountDisabler(jthread thread) is missed (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28968/head:pull/28968
$ git checkout pull/28968

Update a local copy of the PR:
$ git checkout pull/28968
$ git pull https://git.openjdk.org/jdk.git pull/28968/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28968

View PR using the GUI difftool:
$ git pr show -t 28968

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28968.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2025

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into jdk26 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374233: Overloaded constructor MountUnmountDisabler(jthread thread) is missed

Reviewed-by: amenkov, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk26 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk26 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f5249db9c566f87f7fc4f3ed70114a8168babd8b 8374233: Overloaded constructor MountUnmountDisabler(jthread thread) is missed Dec 23, 2025
@openjdk
Copy link

openjdk bot commented Dec 23, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required hotspot-runtime [email protected] labels Dec 23, 2025
@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@sspitsyn The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 23, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@sspitsyn The target repository add is not a valid target for backports.
List of valid target repositories: openjdk/jdk, openjdk/jdk11u, openjdk/jdk11u-dev, openjdk/jdk17u, openjdk/jdk17u-dev, openjdk/jdk21u, openjdk/jdk21u-dev, openjdk/jdk25u, openjdk/jdk25u-dev, openjdk/jdk26u, openjdk/jdk8u, openjdk/jdk8u-dev, openjdk/jfx, openjdk/jfx17u, openjdk/jfx21u, openjdk/jfx25u, openjdk/lilliput-jdk17u, openjdk/lilliput-jdk21u, openjdk/lilliput-jdk25u, openjdk/shenandoah-jdk21u, openjdk/shenandoah-jdk8u.
Supplying the organization/group prefix is optional.

@sspitsyn
Copy link
Contributor Author

/label add serviceability

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@sspitsyn
The serviceability label was successfully added.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 24, 2025
@sspitsyn
Copy link
Contributor Author

Thank you for review, Alex!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required hotspot-runtime [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review serviceability [email protected]

Development

Successfully merging this pull request may close these issues.

3 participants