8374321: Fix undefined reference to 'png_init_filter_functions_lsx' after 8371914

[haominw]

A simple mistake caused undefined reference to 'png_init_filter_functions_lsx'.
The problem has been solved after the following modifications.

diff --git a/make/modules/java.desktop/lib/ClientLibraries.gmk b/make/modules/java.desktop/lib/ClientLibraries.gmk
index f273065a6df..b76cb8dc4e3 100644
--- a/make/modules/java.desktop/lib/ClientLibraries.gmk
+++ b/make/modules/java.desktop/lib/ClientLibraries.gmk
@@ -164,7 +164,7 @@ ifeq ($(ENABLE_HEADLESS_ONLY), false)
 
   ifeq ($(USE_EXTERNAL_LIBPNG), false)
     LIBSPLASHSCREEN_HEADER_DIRS += libsplashscreen/libpng
-    LIBSPLASHSCREEN_CFLAGS += -DPNG_NO_MMX_CODE -DPNG_ARM_NEON_OPT=0
+    LIBSPLASHSCREEN_CFLAGS += -DPNG_NO_MMX_CODE -DPNG_ARM_NEON_OPT=0 \
       -DPNG_ARM_NEON_IMPLEMENTATION=0 -DPNG_LOONGARCH_LSX_OPT=0
 
     ifeq ($(call isTargetOs, linux)+$(call isTargetCpuArch, ppc), true+true)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issue

• JDK-8374321: Fix undefined reference to 'png_init_filter_functions_lsx' after 8371914 (Bug - P4)

Reviewers

• Jie Fu (@DamonFool - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28974/head:pull/28974
$ git checkout pull/28974

Update a local copy of the PR:
$ git checkout pull/28974
$ git pull https://git.openjdk.org/jdk.git pull/28974/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28974

View PR using the GUI difftool:
$ git pr show -t 28974

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28974.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back wanghaomin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@haominw This change is no longer ready for integration - check the PR body for details.

[openjdk]

@haominw The following labels will be automatically applied to this pull request:

• build
• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (29553043)

[DamonFool]

Looks reasonable to me.

[haominw]

/integrate

[openjdk]

@haominw
Your change (at version 2955304) is now ready to be sponsored by a Committer.

[haominw]

@DamonFool Thanks. Jiege, Could you sponsor it?

[mrserb]

Please wait until GA completion.

[jayathirthrao]

Please re-submit failing github actions.

[jayathirthrao]

I am checking for our CI builds with this change. Once they are green will approve.

/reviewers 2 reviewer

[openjdk]

@jayathirthrao
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

[mrserb]

linux-x64 seems a common issue right now across all PRs.