8374322: TestMemoryWithSubgroups.java fails Permission denied #28975
+11
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
Test containers/docker/TestMemoryWithSubgroups.java fails on some docker images. If the default user inside docker is non root user, test will report fails "mkdir: cannot create directory '/sys/fs/cgroup/memory': Permission denied". I think it's better to throw SkippedException rather than report failure when it's do not have root permission inside docker.
Change has been verified locally on ubuntu22(cgroup v2). Test-fix only, no risk.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28975/head:pull/28975$ git checkout pull/28975Update a local copy of the PR:
$ git checkout pull/28975$ git pull https://git.openjdk.org/jdk.git pull/28975/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28975View PR using the GUI difftool:
$ git pr show -t 28975Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28975.diff
Using Webrev
Link to Webrev Comment