8371924: --mac-app-store should be accepted option for app image signing by alexeysemenyukoracle · Pull Request #30346 · openjdk/jdk

alexeysemenyukoracle · 2026-03-20T19:22:57Z

Support the use of "--mac-app-store" option when signing predefined app image.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8371924: --mac-app-store should be accepted option for app image signing (Enhancement - P4)

Reviewers

Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30346/head:pull/30346
$ git checkout pull/30346

Update a local copy of the PR:
$ git checkout pull/30346
$ git pull https://git.openjdk.org/jdk.git pull/30346/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30346

View PR using the GUI difftool:
$ git pr show -t 30346

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30346.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2026-03-20T19:24:55Z

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-03-20T19:26:34Z

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371924: --mac-app-store should be accepted option for app image signing

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

d85fbd3: 8370138: C2: clean up Matcher::use_asm_for_ldiv_by_con can
f1169bf: 8378195: guarantee(static_cast(_oops_size) == align_up(code_buffer->total_oop_size(), oopSize)) failed: failed: 12272 != 77808
2095051: 8380219: Interpreter debugging would be easier if InterpreterCodelets could print their assembly code
... and 39 more: https://git.openjdk.org/jdk/compare/b79449f0938c2abd63d44d613a0de6720913699f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2026-03-20T19:27:25Z

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

…entitlements validation of additional launchers in two-phase app image packaging/signing scenarios; add missing verifyMutable() calls; SigningAppImageTwoStepsTest: follow-up change

alexeysemenyukoracle · 2026-03-23T15:06:21Z

@sashamatveev PTAL

mlbridge · 2026-03-23T15:12:02Z

Webrevs

01: Full - Incremental (465541c7)
00: Full (f414ff15)

sashamatveev

If I remember correctly we used to read app store value from .jpackage.xml when doing predefined app image signing to figure out how we should sign it. What is good reason to sign predefined app image for app store if it was not generated for app store?

sashamatveev · 2026-03-23T22:58:16Z

src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacFromOptions.java

+        if (MAC_APP_STORE.containsIn(options)) {
+            appStore = MAC_APP_STORE.getFrom(options);
+        } else if (PREDEFINED_APP_IMAGE.containsIn(options)) {
            final var appImageFileOptions = appBuilder.externalApplication().orElseThrow().extra();
            appStore = MAC_APP_STORE.getFrom(appImageFileOptions);
        } else {
-            appStore = MAC_APP_STORE.getFrom(options);
+            appStore = false;


I do not see any difference between old and new code. Can you explain?

The old code read the "app-store" property from the predefined image and ignored the value specified on the command line. The new code reads "app-store" property from the command line first. If not found, it reads it from the predefined image.

sashamatveev · 2026-03-23T23:25:42Z

test/jdk/tools/jpackage/macosx/SigningAppImageTest.java


        var testAL = new AdditionalLauncher("testAL");
        testAL.applyTo(cmd);
-        cmd.executeAndAssertHelloAppImageCreated();


Why it is removed?

Because it runs jpackage without signing and duplicates line 70.

alexeysemenyukoracle · 2026-03-24T00:29:24Z

What is good reason to sign predefined app image for app store if it was not generated for app store?

The app image signing command should sign any given app image. The app image can be one created by jpackage or a fully customized one. A missing flag in the ".jpackage.xml" file should not prevent a user from signing an app image for use with the App Store.

sashamatveev

Looks good.

alexeysemenyukoracle · 2026-03-24T01:16:03Z

/integrate

openjdk · 2026-03-24T01:17:42Z

Going to push as commit e0fe86b.
Since your change was applied there have been 42 commits pushed to the master branch:

d85fbd3: 8370138: C2: clean up Matcher::use_asm_for_ldiv_by_con can
f1169bf: 8378195: guarantee(static_cast(_oops_size) == align_up(code_buffer->total_oop_size(), oopSize)) failed: failed: 12272 != 77808
2095051: 8380219: Interpreter debugging would be easier if InterpreterCodelets could print their assembly code
... and 39 more: https://git.openjdk.org/jdk/compare/b79449f0938c2abd63d44d613a0de6720913699f...master

Your commit was automatically rebased without conflicts.

openjdk · 2026-03-24T01:17:50Z

@alexeysemenyukoracle Pushed as commit e0fe86b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 20, 2026

alexeysemenyukoracle force-pushed the JDK-8371924 branch 2 times, most recently from 0221326 to b6aa63d Compare March 22, 2026 19:21

alexeysemenyukoracle added 4 commits March 22, 2026 15:23

8371924: --mac-app-store should be accepted option for app image signing

1f5ce2d

LauncherVerifier: better logging of entitlements validation

4e2bead

SigningAppImageTest: bugfix

b40c0fc

JPackageCommand: enhance usePredefinedAppImage() to enable automatic …

cd39555

…entitlements validation of additional launchers in two-phase app image packaging/signing scenarios; add missing verifyMutable() calls; SigningAppImageTwoStepsTest: follow-up change

alexeysemenyukoracle force-pushed the JDK-8371924 branch from b6aa63d to cd39555 Compare March 22, 2026 19:23

alexeysemenyukoracle added 2 commits March 23, 2026 11:01

Update copyright year

4c0d9f2

Apply blessed-modifier-order.sh

f414ff1

alexeysemenyukoracle marked this pull request as ready for review March 23, 2026 15:06

openjdk bot added the rfr Pull request is ready for review label Mar 23, 2026

LauncherVerifier: log message reworded

465541c

sashamatveev reviewed Mar 23, 2026

View reviewed changes

sashamatveev approved these changes Mar 24, 2026

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 24, 2026

openjdk bot added the integrated Pull request has been integrated label Mar 24, 2026

openjdk bot closed this Mar 24, 2026

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2026

Conversation

alexeysemenyukoracle commented Mar 20, 2026 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Mar 20, 2026

Uh oh!

openjdk bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexeysemenyukoracle commented Mar 23, 2026

Uh oh!

mlbridge bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

sashamatveev left a comment

Choose a reason for hiding this comment

Uh oh!

sashamatveev Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

alexeysemenyukoracle Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

sashamatveev Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

alexeysemenyukoracle Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

alexeysemenyukoracle commented Mar 24, 2026

Uh oh!

sashamatveev left a comment

Choose a reason for hiding this comment

Uh oh!

alexeysemenyukoracle commented Mar 24, 2026

Uh oh!

openjdk bot commented Mar 24, 2026

Uh oh!

openjdk bot commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

alexeysemenyukoracle commented Mar 20, 2026 •

edited by openjdk bot

Loading

openjdk bot commented Mar 20, 2026 •

edited

Loading

openjdk bot commented Mar 20, 2026 •

edited

Loading

mlbridge bot commented Mar 23, 2026 •

edited

Loading