Skip to content

8379016: Improve double_keccak() intrinsic on ARM when SHA3 instructions are not available - #32049

Draft
smemery wants to merge 3 commits into
openjdk:masterfrom
smemery:JDK-8379016
Draft

8379016: Improve double_keccak() intrinsic on ARM when SHA3 instructions are not available#32049
smemery wants to merge 3 commits into
openjdk:masterfrom
smemery:JDK-8379016

Conversation

@smemery

@smemery smemery commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

This enhancement provides AArch64 GPR intrinsics for doubleKeccak(). Previously, only SIMD (Neon) intrinsics were implemented for doubleKeccak() on AArch64 systems. Performance gains for ML-KEM and ML-DSA benchmarks improve 2 to 9% with the GPR intrinsics.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8379016: Improve double_keccak() intrinsic on ARM when SHA3 instructions are not available (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32049/head:pull/32049
$ git checkout pull/32049

Update a local copy of the PR:
$ git checkout pull/32049
$ git pull https://git.openjdk.org/jdk.git pull/32049/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32049

View PR using the GUI difftool:
$ git pr show -t 32049

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32049.diff

@bridgekeeper

bridgekeeper Bot commented Jul 26, 2026

Copy link
Copy Markdown

👋 Welcome back semery! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 26, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 26, 2026
@openjdk

openjdk Bot commented Jul 26, 2026

Copy link
Copy Markdown

@smemery The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented Jul 26, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-compiler. This can be overridden with the /reviewers command.

@smemery

smemery commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

/label add security

@openjdk openjdk Bot added the security security-dev@openjdk.org label Jul 26, 2026
@openjdk

openjdk Bot commented Jul 26, 2026

Copy link
Copy Markdown

@smemery
The security label was successfully added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant