8379016: Improve double_keccak() intrinsic on ARM when SHA3 instructions are not available - #32049
Draft
smemery wants to merge 3 commits into
Draft
8379016: Improve double_keccak() intrinsic on ARM when SHA3 instructions are not available#32049smemery wants to merge 3 commits into
smemery wants to merge 3 commits into
Conversation
…ons are not available
|
👋 Welcome back semery! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
Contributor
Author
|
/label add security |
|
@smemery |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enhancement provides AArch64 GPR intrinsics for doubleKeccak(). Previously, only SIMD (Neon) intrinsics were implemented for doubleKeccak() on AArch64 systems. Performance gains for ML-KEM and ML-DSA benchmarks improve 2 to 9% with the GPR intrinsics.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32049/head:pull/32049$ git checkout pull/32049Update a local copy of the PR:
$ git checkout pull/32049$ git pull https://git.openjdk.org/jdk.git pull/32049/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 32049View PR using the GUI difftool:
$ git pr show -t 32049Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32049.diff