Skip to content

8389126: Serial: Push Full GC roots onto the marking stack - #32052

Open
albertnetymk wants to merge 1 commit into
openjdk:masterfrom
albertnetymk:s1-full-gc-refactor
Open

8389126: Serial: Push Full GC roots onto the marking stack#32052
albertnetymk wants to merge 1 commit into
openjdk:masterfrom
albertnetymk:s1-full-gc-refactor

Conversation

@albertnetymk

@albertnetymk albertnetymk commented Jul 27, 2026

Copy link
Copy Markdown
Member

Serial Full GC currently follows roots directly through follow_root and follow_object, while oops found during object scanning are pushed onto the marking stack. Roots and other oops require the same marking behavior, so this cleanup applies mark_and_push_closure to roots as well and drains the stack after each root group. With roots using the same traversal path as other oops, FollowRootClosure and follow_root can be removed. This leaves follow_object with one caller, so its body is moved into follow_stack.

micro:vm.gc.SystemGC is perf-neurtral.

Test: tier1



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8389126: Serial: Push Full GC roots onto the marking stack (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32052/head:pull/32052
$ git checkout pull/32052

Update a local copy of the PR:
$ git checkout pull/32052
$ git pull https://git.openjdk.org/jdk.git pull/32052/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32052

View PR using the GUI difftool:
$ git pr show -t 32052

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32052.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jul 27, 2026

Copy link
Copy Markdown

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 27, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jul 27, 2026
@openjdk

openjdk Bot commented Jul 27, 2026

Copy link
Copy Markdown

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented Jul 27, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-gc. This can be overridden with the /reviewers command.

@albertnetymk albertnetymk changed the title s1-full-gc-refactor 8389126 Jul 27, 2026
@openjdk openjdk Bot changed the title 8389126 8389126: Serial: Push Full GC roots onto the marking stack Jul 27, 2026
@openjdk openjdk Bot added the rfr Pull request is ready for review label Jul 27, 2026
@mlbridge

mlbridge Bot commented Jul 27, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant