8389126: Serial: Push Full GC roots onto the marking stack - #32052
8389126: Serial: Push Full GC roots onto the marking stack#32052albertnetymk wants to merge 1 commit into
Conversation
|
👋 Welcome back ayang! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@albertnetymk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
Serial Full GC currently follows roots directly through
follow_rootandfollow_object, while oops found during object scanning are pushed onto the marking stack. Roots and other oops require the same marking behavior, so this cleanup appliesmark_and_push_closureto roots as well and drains the stack after each root group. With roots using the same traversal path as other oops,FollowRootClosureandfollow_rootcan be removed. This leavesfollow_objectwith one caller, so its body is moved intofollow_stack.micro:vm.gc.SystemGCis perf-neurtral.Test: tier1
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32052/head:pull/32052$ git checkout pull/32052Update a local copy of the PR:
$ git checkout pull/32052$ git pull https://git.openjdk.org/jdk.git pull/32052/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 32052View PR using the GUI difftool:
$ git pr show -t 32052Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32052.diff
Using Webrev
Link to Webrev Comment