Skip to content

8379830: The warnings for value-based classes need updating to include use of the Reference API - #32055

Open
liach wants to merge 2 commits into
openjdk:jdk27from
liachmodded:doc/vbc-ref
Open

8379830: The warnings for value-based classes need updating to include use of the Reference API#32055
liach wants to merge 2 commits into
openjdk:jdk27from
liachmodded:doc/vbc-ref

Conversation

@liach

@liach liach commented Jul 27, 2026

Copy link
Copy Markdown
Member

The warnings for value-based classes does not mention the use of VBC instances in Reference objects. We are adding warnings for failures in JEP 401 integration; and it's beneficial for us to add something in 27 before JEP 401 lands in 28.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8389188 to be approved

Issues

  • JDK-8379830: The warnings for value-based classes need updating to include use of the Reference API (Enhancement - P3)
  • JDK-8389188: The warnings for value-based classes need updating to include use of the Reference API (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32055/head:pull/32055
$ git checkout pull/32055

Update a local copy of the PR:
$ git checkout pull/32055
$ git pull https://git.openjdk.org/jdk.git pull/32055/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32055

View PR using the GUI difftool:
$ git pr show -t 32055

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32055.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jul 27, 2026

Copy link
Copy Markdown

👋 Welcome back liach! A progress list of the required criteria for merging this PR into jdk27 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 27, 2026

Copy link
Copy Markdown

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8379830: The warnings for value-based classes need updating to include use of the Reference API

Reviewed-by: dholmes, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk27 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk27 branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title 8379830 8379830: The warnings for value-based classes need updating to include use of the Reference API Jul 27, 2026
@openjdk openjdk Bot added javadoc javadoc-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Jul 27, 2026
@openjdk

openjdk Bot commented Jul 27, 2026

Copy link
Copy Markdown

@liach The following labels will be automatically applied to this pull request:

  • core-libs
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jul 27, 2026
@mlbridge

mlbridge Bot commented Jul 27, 2026

Copy link
Copy Markdown

Webrevs

@openjdk openjdk Bot added ready Pull request is ready to be integrated csr Pull request needs approved CSR before integration and removed ready Pull request is ready to be integrated labels Jul 27, 2026
@liach

liach commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

I wrote a CSR documenting the exact changes; please help review.

Comment thread src/java.base/share/classes/java/lang/doc-files/ValueBased.html Outdated
Comment on lines 72 to 73
<p>Identity-related behavior of value-based classes may change in a future release.
For example, synchronization may fail.</p>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expanded this part as well:

For example, synchronization may fail, or use as a referent object may throw an exception.

but it isn't critical.

@openjdk openjdk Bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org javadoc javadoc-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

4 participants