8379830: The warnings for value-based classes need updating to include use of the Reference API - #32055
8379830: The warnings for value-based classes need updating to include use of the Reference API#32055liach wants to merge 2 commits into
Conversation
|
👋 Welcome back liach! A progress list of the required criteria for merging this PR into |
|
@liach This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
|
I wrote a CSR documenting the exact changes; please help review. |
| <p>Identity-related behavior of value-based classes may change in a future release. | ||
| For example, synchronization may fail.</p> |
There was a problem hiding this comment.
I would have expanded this part as well:
For example, synchronization may fail, or use as a referent object may throw an exception.
but it isn't critical.
The warnings for value-based classes does not mention the use of VBC instances in Reference objects. We are adding warnings for failures in JEP 401 integration; and it's beneficial for us to add something in 27 before JEP 401 lands in 28.
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32055/head:pull/32055$ git checkout pull/32055Update a local copy of the PR:
$ git checkout pull/32055$ git pull https://git.openjdk.org/jdk.git pull/32055/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 32055View PR using the GUI difftool:
$ git pr show -t 32055Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32055.diff
Using Webrev
Link to Webrev Comment