8370493: [ubsan] aotMapLogger.cpp:864:44: runtime error: applying non-zero offset NNNNN to null pointer - #32057
8370493: [ubsan] aotMapLogger.cpp:864:44: runtime error: applying non-zero offset NNNNN to null pointer#32057matias9927 wants to merge 1 commit into
Conversation
…-zero offset NNNNN to null pointer
|
👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@matias9927 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
dholmes-ora
left a comment
There was a problem hiding this comment.
Seems a reasonable workaround. Thanks.
The UBSAN tool found undefined behavior in the aotMapLogger which relates to JDK-8366062. This patch applies an updated fix for both issues that places
address + offsetcalculations in archiveUtils with proper casting to avoid the UBSAN error. Verified with tier 1-5 tests.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32057/head:pull/32057$ git checkout pull/32057Update a local copy of the PR:
$ git checkout pull/32057$ git pull https://git.openjdk.org/jdk.git pull/32057/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 32057View PR using the GUI difftool:
$ git pr show -t 32057Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32057.diff
Using Webrev
Link to Webrev Comment