Skip to content

8376251: [macos] java/awt/Frame/I18NTitle.java fails on MacOS (JDK-8355884)#2565

Open
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
GoeLin:goetz_backport_8355884
Open

8376251: [macos] java/awt/Frame/I18NTitle.java fails on MacOS (JDK-8355884)#2565
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
GoeLin:goetz_backport_8355884

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 23, 2026

This fixes an issue spotted by Mikael Sterner, thanks!!

Unfortunately the bug "8355884: [macos] java/awt/Frame/I18NTitle.java fails on MacOS" is closed.

Addon: I opened https://bugs.openjdk.org/browse/JDK-8376251 for this.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8376251 needs maintainer approval

Issue

  • JDK-8376251: [macos] java/awt/Frame/I18NTitle.java fails on MacOS (JDK-8355884) (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2565/head:pull/2565
$ git checkout pull/2565

Update a local copy of the PR:
$ git checkout pull/2565
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2565/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2565

View PR using the GUI difftool:
$ git pr show -t 2565

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2565.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 23, 2026

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 23, 2026

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8376251: [macos] java/awt/Frame/I18NTitle.java fails on MacOS (JDK-8355884)

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Jan 23, 2026

⚠️ @GoeLin the issue with id 8355884 does not exist in project JDK.

@GoeLin GoeLin changed the title backport 8355884 backport 2eaddd5b0a18d762ced7fea845ffa1a9e675e095 Jan 23, 2026
@openjdk
Copy link

openjdk bot commented Jan 23, 2026

⚠️ @GoeLin the issue with id 8355884 from commit 2eaddd5b0a18d762ced7fea845ffa1a9e675e095 does not exist in project JDK.

@jerboaa
Copy link
Contributor

jerboaa commented Jan 23, 2026

@GoeLin For those cases we should be using Backport JDK-8355884 in the PR title so it's recognized as a backport with an unknown sha. Could you try that please?

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean from openjdk/jdk25u-dev@52e1e73

@jerboaa
Copy link
Contributor

jerboaa commented Jan 23, 2026

Asked here if it's meant to be private: https://mail.openjdk.org/pipermail/jdk-dev/2026-January/010787.html

@GoeLin GoeLin changed the title backport 2eaddd5b0a18d762ced7fea845ffa1a9e675e095 backport 52e1e739afd419e8a5d153a27f5d145c498e4ebf Jan 23, 2026
@openjdk
Copy link

openjdk bot commented Jan 23, 2026

⚠️ @GoeLin the issue with id 8355884 from commit 52e1e739afd419e8a5d153a27f5d145c498e4ebf does not exist in project JDK.

@GoeLin
Copy link
Member Author

GoeLin commented Jan 24, 2026

Hmm, the sha is known, I got it wrong somehow. But fixing this did not help either...

@GoeLin GoeLin changed the title backport 52e1e739afd419e8a5d153a27f5d145c498e4ebf Backport JDK-8355884 Jan 24, 2026
@GoeLin GoeLin changed the title Backport JDK-8355884 8376251: [macos] java/awt/Frame/I18NTitle.java fails on MacOS Jan 24, 2026
@openjdk openjdk bot added approval Requires approval; will be removed when approval is received rfr Pull request is ready for review labels Jan 24, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 24, 2026

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jan 25, 2026
@jerboaa
Copy link
Contributor

jerboaa commented Jan 26, 2026

OK. Bot seems to be happy now and it's ready for integration. Out of curiosity, has anybody run the mentioned test:

test/jdk/java/awt/Frame/I18NTitle.java

@jerboaa
Copy link
Contributor

jerboaa commented Jan 26, 2026

Added the original JDK number so that it'll be grepable in logs.

@openjdk openjdk bot changed the title 8376251: [macos] java/awt/Frame/I18NTitle.java fails on MacOS 8376251: [macos] java/awt/Frame/I18NTitle.java fails on MacOS (JDK-8355884) Jan 26, 2026
@GoeLin
Copy link
Member Author

GoeLin commented Jan 26, 2026

Nice that it was finally accepted by the bots.
I will run the test before I push.

kiivihal added a commit to delving/sip-creator that referenced this pull request Feb 19, 2026
Temurin 21.0.8+ has a font rendering regression on macOS that causes
random characters to disappear from Swing components. This is a known
JDK bug with an upstream fix backported to 21.0.11 (due April 2026).

Pin macOS native packaging builds to 21.0.7 which does not have this
issue. Other platforms continue using the latest JDK 21.

Refs:
- adoptium/adoptium-support#1393
- openjdk/jdk21u-dev#2565

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants

Comments