8354469: Keytool exposes the password in plain text when command is piped using | grep#2617
Draft
GoeLin wants to merge 1 commit intoopenjdk:pr/2616from
Draft
8354469: Keytool exposes the password in plain text when command is piped using | grep#2617GoeLin wants to merge 1 commit intoopenjdk:pr/2616from
GoeLin wants to merge 1 commit intoopenjdk:pr/2616from
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
Contributor
|
Regarding the manual EchoPassword test, you could check for the readPassword() method taking a locale in Console and if not found don't include the instructions for the last two tests (if any poor soul really does them manually). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit of src/java.base/share/classes/sun/security/util/resources/security.properties
applied to sun/security/util/Resources.java as
"8345940: Migrate security-related resources from Java classes to properties files" not in 21.
test/jdk/sun/security/util/Resources/Usages.java
Trivial resolve as "8338411: Implement JEP 486: Permanently Disable the Security Manager" is not in 21.
The new test jdk/sun/security/tools/keytool/EchoPassword.java fails for passwords with non-ascii characters.
I think this is because many changes to pass the encoding around are missin in 21, especially https://bugs.openjdk.org/browse/JDK-8330276: Console methods with explicit Locale
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2617/head:pull/2617$ git checkout pull/2617Update a local copy of the PR:
$ git checkout pull/2617$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2617/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2617View PR using the GUI difftool:
$ git pr show -t 2617Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2617.diff