8056039: Hotspot does not compile with clang 3.4 on Linux #736
+3
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost clean backport of JDK-8056039 that removes
local_vsnprintffrom the codebase, making it easier to build withclang.This will make it easier to backport JDK-8369226 to restore MacOS/GHA builds, which are now failing.
Backport is not clean because the changes in
vm/utilities/globalDefinitions_gcc.hppare already in place since this commit for JFR.Passes tier1 tests on Linux but for usual suspeccts.
Windows and MacOS GHA builds fail, but are unrelated.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/736/head:pull/736$ git checkout pull/736Update a local copy of the PR:
$ git checkout pull/736$ git pull https://git.openjdk.org/jdk8u-dev.git pull/736/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 736View PR using the GUI difftool:
$ git pr show -t 736Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/736.diff
Using Webrev
Link to Webrev Comment