Skip to content

Conversation

@vieiro
Copy link
Contributor

@vieiro vieiro commented Dec 22, 2025

Almost clean backport of JDK-8056039 that removes local_vsnprintf from the codebase, making it easier to build with clang.

This will make it easier to backport JDK-8369226 to restore MacOS/GHA builds, which are now failing.

Backport is not clean because the changes in vm/utilities/globalDefinitions_gcc.hpp are already in place since this commit for JFR.

Passes tier1 tests on Linux but for usual suspeccts.

Windows and MacOS GHA builds fail, but are unrelated.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8056039 needs maintainer approval

Issue

  • JDK-8056039: Hotspot does not compile with clang 3.4 on Linux (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/736/head:pull/736
$ git checkout pull/736

Update a local copy of the PR:
$ git checkout pull/736
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/736/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 736

View PR using the GUI difftool:
$ git pr show -t 736

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/736.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 22, 2025

👋 Welcome back avieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 22, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport a2d9ba3fd6712b2406d035de7614e8da86bac237 8056039: Hotspot does not compile with clang 3.4 on Linux Dec 22, 2025
@openjdk
Copy link

openjdk bot commented Dec 22, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Dec 22, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 22, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant