7904175: Empty option value can crash jextract#303
Open
nizarbenalla wants to merge 1 commit intoopenjdk:masterfrom
Open
7904175: Empty option value can crash jextract#303nizarbenalla wants to merge 1 commit intoopenjdk:masterfrom
nizarbenalla wants to merge 1 commit intoopenjdk:masterfrom
Conversation
-issue an error
|
👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into |
|
@nizarbenalla This change is no longer ready for integration - check the PR body for details. |
JornVernee
approved these changes
Mar 31, 2026
Member
JornVernee
left a comment
There was a problem hiding this comment.
I'm not super familiar with the option parser code, but your changes look good to me.
Member
Author
|
Thank you for the review /integrate |
|
@nizarbenalla |
Member
Author
|
/template append |
|
@nizarbenalla The pull request template has been appended to the pull request body |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.
Passing empty option values to jextract causes it to crash, this patch prevent that to happen.
Please add the following to the description of the pull request:
please mention these as well, as this helps reviewers understand the changes that have been made.
For 1 and 2 it is also okay to refer to the JBS ticket, if that already contains a comprehensive
problem description.
Please test your pull request before submitting it by running
./gradlew jtreg. If you'renot able to test locally on your machine, please indicate this in the pull request description,
and indicate which testing has been done instead (or indicate that no testing has been done).
It is possible to run tests through Github actions if you enable them for your fork (this is free).
Github actions can be enabled for your fork from the 'Actions' tab. The tests will then run
automatically after the pull request has been created.
Progress
Error
- [x] I confirm that I make this contribution in accordance with the [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/303/head:pull/303$ git checkout pull/303Update a local copy of the PR:
$ git checkout pull/303$ git pull https://git.openjdk.org/jextract.git pull/303/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 303View PR using the GUI difftool:
$ git pr show -t 303Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/303.diff
Using Webrev
Link to Webrev Comment