8389921: Changes in hlsl files do not dirty build sources - #2252
Conversation
|
👋 Welcome back nlisker! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
…hlsl_files_do_not_dirty_build_sources
|
@arapte and/or @lukostyra. please review. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
arapte
left a comment
There was a problem hiding this comment.
Sanity build is good, suggesting a minor change.
| }).withPropertyName("hlslSources") | ||
| inputs.file("$prismD3DSource/PassThroughVS.hlsl").withPropertyName("PassThroughVsSources") | ||
| outputs.dir "$buildDir/headers/PrismD3D/" |
There was a problem hiding this comment.
Please remove the .withPropertyName("") calls, as thee seem un-required for this change.
-idebug info.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/2252/head:pull/2252$ git checkout pull/2252Update a local copy of the PR:
$ git checkout pull/2252$ git pull https://git.openjdk.org/jfx.git pull/2252/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2252View PR using the GUI difftool:
$ git pr show -t 2252Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/2252.diff
Using Webrev
Link to Webrev Comment