7904172: JTReg should add --enable-native-access=ALL-UNNAMED in /native actions

[sormuras]

Please review this change adding --enable-native-access=ALL-UNNAMED to the list of Java test runtime command-line arguments for actions with /native option -- unless there is one or more explicit custom --enable-native-access arguments present.

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• CODETOOLS-7904172: JTReg should add --enable-native-access=ALL-UNNAMED in /native actions (Enhancement - P3)

Reviewers

• Leonid Mesnik (@lmesnik - no project role)
• Iris Clark (@irisclark - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/319/head:pull/319
$ git checkout pull/319

Update a local copy of the PR:
$ git checkout pull/319
$ git pull https://git.openjdk.org/jtreg.git pull/319/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 319

View PR using the GUI difftool:
$ git pr show -t 319

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/319.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7904172: JTReg should add --enable-native-access=ALL-UNNAMED in /native actions

Reviewed-by: lmesnik, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• cef4547: 7904176: JTReg should find inherited main methods
• 7c8ef07: 7904177: Add pull request template for openjdk/jtreg

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 05: Full - Incremental (897d6823)
• 04: Full - Incremental (634643f5)
• 03: Full - Incremental (4418ef54)
• 02: Full - Incremental (98813cc3)
• 01: Full - Incremental (b558caed)
• 00: Full (49f4c88b)

[sormuras]

Running bash build/make.sh testnativepath works fine in GH Codespaces. 🤔

Ah, Module#isNativeAccessEnabled() was added in Java 22.

And --enable-native-access was introduce in Java 17.

[lmesnik]

I think that fix looks good and useful.

[irisclark]

Are planning to eventually provide support for explicitly named modules (i.e. --enable-native-access module[,module...], see java mapage)?

You might want to call out this /native option in the Tag Specification?

[sormuras]

Thanks for all the reviews and the approval, Iris!

Are planning to eventually provide support for explicitly named modules (i.e. --enable-native-access module[,module...], see java mapage)?

No, not yet. You may continue to do so via an explicit listing in the (VM) options arguments. Hence the "seenEnableNativeAccess" logic in this PR.

You might want to call out this /native option in the Tag Specification?

Right. Will add it to the spec (and FAQ).