8380282: [lworld] Problem-list several SA/jhsdb tests when running with --enable-preview by Arraying · Pull Request #2236 · openjdk/valhalla

Arraying · 2026-03-17T10:06:43Z

Hi,

The following tests fail with --enable-preview and have been bulk problemlisted:

resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java
serviceability/sa/CDSJMapClstats.java
serviceability/sa/ClhsdbDumpheap.java
serviceability/sa/ClhsdbJhisto.java
serviceability/sa/ClhsdbJstackWithConcurrentLock.java
serviceability/sa/TestJmapCore.java
serviceability/sa/TestJmapCoreMetaspace.java
sun/tools/jhsdb/HeapDumpTest.java
sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java
sun/tools/jhsdb/JShellHeapDumpTest.java

Testing on Linux (x64, AArch64), macOS (x64, AArch64), Windows x64:

tier 1 sanity test
:hotspot_serviceability (most of the SA tests), with and without preview
:hotspot_resourcehogs (some SA tests), with and without preview
:svc_tools (some jhsdb tests), with and without preview

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

JDK-8380282: [lworld] Problem-list several SA/jhsdb tests when running with --enable-preview (Bug - P4)

Reviewers

Coleen Phillimore (@coleenp - Committer) ⚠️ Review applies to 9fd6dda3
Chris Plummer (@plummercj - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2236/head:pull/2236
$ git checkout pull/2236

Update a local copy of the PR:
$ git checkout pull/2236
$ git pull https://git.openjdk.org/valhalla.git pull/2236/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2236

View PR using the GUI difftool:
$ git pr show -t 2236

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2236.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2026-03-17T10:08:23Z

👋 Welcome back phubner! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-03-17T10:09:44Z

@Arraying This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8380282: [lworld] Problem-list several SA/jhsdb tests when running with --enable-preview

Reviewed-by: coleenp, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 125 new commits pushed to the lworld branch:

559e0e4: 8379501: [lworld] Clean up Valhalla flags
f12276a: 8379913: [lworld] AppCDS test asserts with -Xcomp --enable-preview
e0c8622: 8369808: [lworld] 8366837 partially reverted duing 26+15 merge
... and 122 more: https://git.openjdk.org/valhalla/compare/2701ce240beea4fc90aada28a60f7ed822cdd065...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

mlbridge · 2026-03-17T16:32:03Z

Webrevs

plummercj · 2026-03-17T17:30:16Z

What is the motivation for disabling all the SA tests instead of problem listing just the failing tests? How many SA tests are failing with --enable-preview?

coleenp · 2026-03-18T13:03:40Z

I would 100% much rather we programmatically disable them than problem list a list of tests. The ProblemList list is noise that I thought I cleaned out once but it keeps changing. This is a lot better. Also if this fixes this test to not run, it should be removed from the problem list.

ProblemList-enable-preview.txt:serviceability/sa/TestHeapDumpForInvokeDynamic.java                                              8377387 generic-all

alexmenkov · 2026-03-18T19:51:43Z

I agree with Chris.
Although currently SA does not support value objects, the support have to be implemented before value classes out of preview (I believe it happen earlier than we deprecate SA).
As most of the SA test pass, it would be better to keep them running to catch new issues. To me ProblemList-enable-preview is a good place to see what needs to be done.

coleenp · 2026-03-18T20:01:56Z

I feel like this makes extra work in categorizing and triaging issues for something that is going to continue to break in different ways all the time. Maybe we could have one issue to reenable the tests and fix them, if we plan on fixing these in the future.

plummercj · 2026-03-18T20:08:58Z

It is best to detect new failures as they happen, not months down the road when someone decides to disable this change and retest, and then has to figure out what changes caused the new failures.

It looks like only 8 tests out of about 90 tests are failing. Most of the failures I skimmed over already have bugs filed for them. We should get them all problem listed so we have clean results and can then readily detect new failures.

This reverts commit 7bdfce0.

Arraying · 2026-03-24T11:39:06Z

Thanks for the feedback, everyone. I've disabled the tests I found failing, and created JBS issues where necessary.

coleenp

I guess it's only two bugs so not a big effort. Looks good.

Arraying · 2026-03-24T13:33:14Z

@plummercj @alexmenkov could I get a quick svc review/look before I integrate? TIA.

plummercj · 2026-03-24T15:09:14Z

test/hotspot/jtreg/ProblemList-enable-preview.txt

+serviceability/sa/TestJmapCore.java                                                              8380779 generic-all
+serviceability/sa/TestJmapCoreMetaspace.java                                                     8380779 generic-all


The following tests should use 8379925:

serviceability/sa/TestJmapCore.java
serviceability/sa/TestJmapCoreMetaspace.java
serviceability/sa/ClhsdbDumpheap.java

The other 4 are all separate issues and they don't require -XX:-UseCompressedOops to reproduce. I was actually getting ready to do a problem list update myself (already have the diffs in place) but was just holding off until I could get bugs filed. If you want to file them all under 8379925 for now that is ok. I might change them once I file new CRs, but you should update the CR to not require -XX:-UseCompressedOops.

Actually the 8380769 CR is correct for TestHeapDumpForLargeArray.java. I misread it as 8380779

I think you meant 8379920 (8379925 is about /jdk/sun/tools/jhsdb/ tests)
I've closed 8379920 as a dup of 8380779

Either 8379925 or 8379920 is fine. They are dups, so whichever one is kept open.

I filed JDK-8380851 for serviceability/sa/ClhsdbJstackWithConcurrentLock.java

I filed JDK-8380852 for serviceability/sa/CDSJMapClstats.java

I filed JDK-8380853 for the serviceability/sa/ClhsdbJhisto.java failure

plummercj · 2026-03-27T04:53:07Z

@Arraying I have a fix for the following for tests, so please don't problem list them. See #2271

resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java
serviceability/sa/CDSJMapClstats.java
serviceability/sa/ClhsdbJhisto.java
serviceability/sa/ClhsdbJstackWithConcurrentLock.java

Arraying · 2026-03-27T09:48:01Z

@plummercj @alexmenkov thanks for the feedback. I've updated the tests to use 8379925 and removed the ones being addressed in the PR. I'll address the comments in the JBS issues momentarily.

Arraying · 2026-03-27T09:48:17Z

I did not mean to close the PR, but if you think it's easier to do the problemlist changes in your respective feature PRs I'm okay to abandon this.

plummercj

Looks good

Constrain hasSA to non-preview configurations.

7bdfce0

openjdk bot changed the title ~~8380282~~ 8380282: [lworld] Skip SA tests when running with --enable-preview Mar 17, 2026

Arraying marked this pull request as ready for review March 17, 2026 16:25

openjdk bot added the rfr Pull request is ready for review label Mar 17, 2026

Arraying added 2 commits March 24, 2026 09:51

Revert "Constrain hasSA to non-preview configurations."

51d4356

This reverts commit 7bdfce0.

Add tests to the problem list.

9fd6dda

Arraying changed the title ~~8380282: [lworld] Skip SA tests when running with --enable-preview~~ 8380282 Mar 24, 2026

openjdk bot changed the title ~~8380282~~ 8380282: [lworld] Problem-list several SA/jhsdb tests when running with --enable-preview Mar 24, 2026

coleenp approved these changes Mar 24, 2026

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 24, 2026

plummercj reviewed Mar 24, 2026

View reviewed changes

Reviewer feedback.

773b58d

Arraying closed this Mar 27, 2026

Arraying reopened this Mar 27, 2026

plummercj approved these changes Mar 27, 2026

View reviewed changes

		serviceability/sa/TestJmapCore.java 8380779 generic-all
		serviceability/sa/TestJmapCoreMetaspace.java 8380779 generic-all

Conversation

Arraying commented Mar 17, 2026 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Mar 17, 2026

Uh oh!

openjdk bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

plummercj commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coleenp commented Mar 18, 2026

Uh oh!

alexmenkov commented Mar 18, 2026

Uh oh!

coleenp commented Mar 18, 2026

Uh oh!

plummercj commented Mar 18, 2026

Uh oh!

Arraying commented Mar 24, 2026

Uh oh!

coleenp left a comment

Choose a reason for hiding this comment

Uh oh!

Arraying commented Mar 24, 2026

Uh oh!

plummercj Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

plummercj Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

alexmenkov Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

plummercj Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

plummercj Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

plummercj Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

plummercj Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

plummercj commented Mar 27, 2026

Uh oh!

Arraying commented Mar 27, 2026

Uh oh!

Arraying commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

plummercj left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Arraying commented Mar 17, 2026 •

edited by openjdk bot

Loading

openjdk bot commented Mar 17, 2026 •

edited

Loading

mlbridge bot commented Mar 17, 2026 •

edited

Loading

plummercj commented Mar 17, 2026 •

edited

Loading

Arraying commented Mar 27, 2026 •

edited

Loading