8380553: [lworld] Wrong type used in InlineKlass::realloc_result()

[fparain]

Small fix to use the right method for long fields when re-creating a buffered value from a scalarized form.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8380553: [lworld] Wrong type used in InlineKlass::realloc_result() (Bug - P4)

Reviewers

• Stefan Karlsson (@stefank - Committer) ⚠️ Review applies to ccc6350e
• Christian Hagedorn (@chhagedorn - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2250/head:pull/2250
$ git checkout pull/2250

Update a local copy of the PR:
$ git checkout pull/2250
$ git pull https://git.openjdk.org/valhalla.git pull/2250/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2250

View PR using the GUI difftool:
$ git pr show -t 2250

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2250.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fparain This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8380553: [lworld] Wrong type used in InlineKlass::realloc_result()

Reviewed-by: stefank, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the lworld branch:

• bcc3ca6: 8380520: [lworld] compiler/valhalla/inlinetypes/TestTrivialMethods.java fails with -XX:-PreloadClasses after JDK-8380053
• 067e6d8: 8376544: [lworld] Use profiling around acmp to speculate that one operand is a value object
• 19fe8ba: 8379863: [lworld] C2: assert(!value->obj_is_scalar_replaced() || realloc_failures) failed: object should be reallocated already
• ... and 5 more: https://git.openjdk.org/valhalla/compare/738e0cb821dc9fd0d80bdc4d7589be3328c70cfc...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (ae39adf7)
• 00: Full (ccc6350e)

[stefank]

Looks good. There's a typo in the JBS title: realloc_result vs realloc_result.

[chhagedorn]

Good catch!

[chhagedorn]

Thanks for fixing the spacing!

[fparain]

Thanks @stefank @chhagedorn for the reviews.
/integrate

[openjdk]

Going to push as commit 1257fbd.
Since your change was applied there have been 8 commits pushed to the lworld branch:

• bcc3ca6: 8380520: [lworld] compiler/valhalla/inlinetypes/TestTrivialMethods.java fails with -XX:-PreloadClasses after JDK-8380053
• 067e6d8: 8376544: [lworld] Use profiling around acmp to speculate that one operand is a value object
• 19fe8ba: 8379863: [lworld] C2: assert(!value->obj_is_scalar_replaced() || realloc_failures) failed: object should be reallocated already
• ... and 5 more: https://git.openjdk.org/valhalla/compare/738e0cb821dc9fd0d80bdc4d7589be3328c70cfc...lworld

Your commit was automatically rebased without conflicts.

[openjdk]

@fparain Pushed as commit 1257fbd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.