refactor(main): extract run() for testability#54
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
=======================================
Coverage ? 87.32%
=======================================
Files ? 16
Lines ? 2257
Branches ? 0
=======================================
Hits ? 1971
Misses ? 286
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
main() contained the full build pipeline with process::exit on every error, making it impossible to call from tests. This extracts run() with a Result return type and injectable runner and workspace base, then adds four tests covering the orchestration path. Also changes build_policy() to return Result instead of calling process::exit internally. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Philippe Martin <phmartin@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main() contained the full build pipeline with process::exit on every error, making it impossible to call from tests. This extracts run() with a Result return type and injectable runner and workspace base, then adds four tests covering the orchestration path.
Also changes build_policy() to return Result instead of calling process::exit internally.