[tests] add tests in inplace_update_test.go#115
Open
patilpratik1905 wants to merge 1 commit intoopenkruise:masterfrom
Open
[tests] add tests in inplace_update_test.go#115patilpratik1905 wants to merge 1 commit intoopenkruise:masterfrom
patilpratik1905 wants to merge 1 commit intoopenkruise:masterfrom
Conversation
Signed-off-by: Pratik Patil <pratikgpatil1905@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 48.71% 51.93% +3.22%
==========================================
Files 85 87 +2
Lines 4701 4785 +84
==========================================
+ Hits 2290 2485 +195
+ Misses 2208 2089 -119
- Partials 203 211 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
This PR adds unit tests to improve coverage of the inplace_update_test used for generating and applying Pod patch updates.
Added the below functions
TestDefaultGeneratePatchBodyFunc
Validates patch generation by comparing Sandbox and Pod container images, ensuring patches are created only when required and correctly handle partial updates, sidecars, and empty container specs.
TestNewInPlaceUpdateControl
Verifies proper initialization of the in-place update controller with different patch function configurations, ensuring the client and patch function are set correctly.
TestInPlaceUpdateControl_Update_WithCustomPatchFunc
Ensures the update operation safely returns a no-op when a custom patch function produces an empty patch, without errors or unnecessary API calls.
Ⅱ. Does this pull request fix one issue?
No
Ⅲ. Describe how to verify it
Ran make test to check coverage of file
Ⅳ. Special notes for reviews