Skip to content

update labels when claiming#201

Open
furykerry wants to merge 1 commit intoopenkruise:masterfrom
furykerry:feat/claim-labeling
Open

update labels when claiming#201
furykerry wants to merge 1 commit intoopenkruise:masterfrom
furykerry:feat/claim-labeling

Conversation

@furykerry
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

❌ Patch coverage is 57.57576% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.16%. Comparing base (ff612f0) to head (74d1326).
⚠️ Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
pkg/utils/inplaceupdate/inplace_update.go 0.00% 7 Missing ⚠️
pkg/sandbox-manager/infra/sandboxcr/claim.go 50.00% 3 Missing ⚠️
pkg/servers/e2b/create.go 50.00% 1 Missing and 1 partial ⚠️
pkg/servers/e2b/models/extensions.go 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   57.97%   58.16%   +0.19%     
==========================================
  Files          99       99              
  Lines        6027     6098      +71     
==========================================
+ Hits         3494     3547      +53     
- Misses       2291     2306      +15     
- Partials      242      245       +3     
Flag Coverage Δ
unittests 58.16% <57.57%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@AiRanthem AiRanthem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@AiRanthem
Copy link
Member

The labels should be added to the pod either

@kruise-bot
Copy link

New changes are detected. LGTM label has been removed.

Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com>
@kruise-bot
Copy link

@furykerry: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants