Sandbox-manager support filtering sandbox-related custom resources#217
Open
lxs137 wants to merge 1 commit intoopenkruise:masterfrom
Open
Sandbox-manager support filtering sandbox-related custom resources#217lxs137 wants to merge 1 commit intoopenkruise:masterfrom
lxs137 wants to merge 1 commit intoopenkruise:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @lxs137! It looks like this is your first PR to openkruise/agents 🎉 |
lxs137
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #217 +/- ##
==========================================
+ Coverage 61.72% 61.80% +0.07%
==========================================
Files 104 104
Lines 6681 6694 +13
==========================================
+ Hits 4124 4137 +13
Misses 2290 2290
Partials 267 267
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lxs137
force-pushed
the
manager/scoped-informer
branch
2 times, most recently
from
d7e9dba to
143f764
Compare
…ce informer Signed-off-by: menya <lxs137@hotmail.com>
lxs137
force-pushed
the
manager/scoped-informer
branch
from
143f764 to
8989e3b
Compare
Author
|
@furykerry @AiRanthem please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Sandbox-manager support filtering sandbox-related custom resources (Sandbox, SandboxSet, Checkpoint, SandboxTemplate) by namespace and label selector through startup flags, enabling:
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
--sandbox-namespace=<target-ns>, verify that only resources in the specified namespace are watched and managed.--sandbox-label-selector=managed=true, verify that only resources with matching labels are watched.Ⅳ. Special notes for reviews