Skip to content

feat: using memberlist to discover sandbox-manager and sandbox-gateway#220

Open
chengzhycn wants to merge 3 commits intoopenkruise:masterfrom
chengzhycn:feature/memberlist-260309
Open

feat: using memberlist to discover sandbox-manager and sandbox-gateway#220
chengzhycn wants to merge 3 commits intoopenkruise:masterfrom
chengzhycn:feature/memberlist-260309

Conversation

@chengzhycn
Copy link
Copy Markdown

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

AiRanthem and others added 2 commits March 25, 2026 02:00
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Signed-off-by: xianying.czy <xianying.czy@alibaba-inc.com>
@kruise-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chengzhycn
Copy link
Copy Markdown
Author

/assign @AiRanthem @furykerry

Signed-off-by: xianying.czy <xianying.czy@alibaba-inc.com>
@chengzhycn chengzhycn force-pushed the feature/memberlist-260309 branch from a830934 to 050e6e3 Compare March 25, 2026 05:30
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 56.79443% with 124 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.27%. Comparing base (4d5825c) to head (050e6e3).

Files with missing lines Patch % Lines
pkg/sandbox-gateway/server/server.go 0.00% 80 Missing ⚠️
pkg/sandbox-manager/core.go 24.32% 28 Missing ⚠️
pkg/utils/utils.go 0.00% 9 Missing ⚠️
pkg/peers/memberlist.go 93.51% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   61.80%   63.27%   +1.47%     
==========================================
  Files         104      106       +2     
  Lines        6694     6845     +151     
==========================================
+ Hits         4137     4331     +194     
+ Misses       2290     2243      -47     
- Partials      267      271       +4     
Flag Coverage Δ
unittests 63.27% <56.79%> (+1.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants