Skip to content

add configmap cache in manager#221

Open
BH4AWS wants to merge 1 commit intoopenkruise:masterfrom
BH4AWS:feat/feat/auto_inject_csi_runtime_config_3
Open

add configmap cache in manager#221
BH4AWS wants to merge 1 commit intoopenkruise:masterfrom
BH4AWS:feat/feat/auto_inject_csi_runtime_config_3

Conversation

@BH4AWS
Copy link
Copy Markdown
Contributor

@BH4AWS BH4AWS commented Mar 25, 2026

Ⅰ. Describe what this PR does

In sandbox-manager-component, adding cache logic in the sandbox-manager controller to enable fast injection of CSI sidecar and other components during pod creation.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: jicheng.sk <jicheng.sk@alibaba-inc.com>
@kruise-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.80%. Comparing base (4d5825c) to head (e1d08fa).

Files with missing lines Patch % Lines
pkg/sandbox-manager/infra/sandboxcr/cache.go 61.53% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
- Coverage   61.80%   61.80%   -0.01%     
==========================================
  Files         104      104              
  Lines        6694     6707      +13     
==========================================
+ Hits         4137     4145       +8     
- Misses       2290     2293       +3     
- Partials      267      269       +2     
Flag Coverage Δ
unittests 61.80% <72.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants