Skip to content

add sandboxSet Prometheus metrics#223

Merged
furykerry merged 1 commit intoopenkruise:masterfrom
ZhaoQing7892:add_sandboxset_metrics
Mar 26, 2026
Merged

add sandboxSet Prometheus metrics#223
furykerry merged 1 commit intoopenkruise:masterfrom
ZhaoQing7892:add_sandboxset_metrics

Conversation

@ZhaoQing7892
Copy link
Copy Markdown
Contributor

@ZhaoQing7892 ZhaoQing7892 commented Mar 26, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.90%. Comparing base (f647942) to head (4e600f0).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/controller/sandboxset/sandboxset_controller.go 50.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #223   +/-   ##
=======================================
  Coverage   61.90%   61.90%           
=======================================
  Files         104      105    +1     
  Lines        6694     6702    +8     
=======================================
+ Hits         4144     4149    +5     
- Misses       2285     2288    +3     
  Partials      265      265           
Flag Coverage Δ
unittests 61.90% <62.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@furykerry furykerry merged commit c0bd69a into openkruise:master Mar 26, 2026
12 of 13 checks passed
@kruise-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants