Skip to content

Feat/record csi mount config to sandbox annotation#224

Open
BH4AWS wants to merge 1 commit intoopenkruise:masterfrom
BH4AWS:feat/record_csi_mount_config_to_sandbox_annotation
Open

Feat/record csi mount config to sandbox annotation#224
BH4AWS wants to merge 1 commit intoopenkruise:masterfrom
BH4AWS:feat/record_csi_mount_config_to_sandbox_annotation

Conversation

@BH4AWS
Copy link
Copy Markdown
Contributor

@BH4AWS BH4AWS commented Mar 27, 2026

Ⅰ. Describe what this PR does

For sandbox csi volume mount, the config should to be recorded in sandbox annotation.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BH4AWS BH4AWS force-pushed the feat/record_csi_mount_config_to_sandbox_annotation branch from ef2b361 to 1b1abc9 Compare March 27, 2026 16:00
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.37%. Comparing base (c0bd69a) to head (4aeb1dc).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/servers/e2b/create.go 64.28% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   61.80%   62.37%   +0.57%     
==========================================
  Files         105      106       +1     
  Lines        6702     6841     +139     
==========================================
+ Hits         4142     4267     +125     
- Misses       2293     2302       +9     
- Partials      267      272       +5     
Flag Coverage Δ
unittests 62.37% <64.28%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

}
for k, v := range request.Metadata {
annotations[k] = v
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in basicSandboxCreateModifier, request.Metadata is already copied to annotations, no need to copy again.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: jicheng.sk <jicheng.sk@alibaba-inc.com>
@BH4AWS BH4AWS force-pushed the feat/record_csi_mount_config_to_sandbox_annotation branch from 1b1abc9 to 4aeb1dc Compare March 28, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants