Feat/record csi mount config to sandbox annotation#224
Feat/record csi mount config to sandbox annotation#224BH4AWS wants to merge 1 commit intoopenkruise:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ef2b361 to
1b1abc9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #224 +/- ##
==========================================
+ Coverage 61.80% 62.37% +0.57%
==========================================
Files 105 106 +1
Lines 6702 6841 +139
==========================================
+ Hits 4142 4267 +125
- Misses 2293 2302 +9
- Partials 267 272 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
| for k, v := range request.Metadata { | ||
| annotations[k] = v | ||
| } |
There was a problem hiding this comment.
in basicSandboxCreateModifier, request.Metadata is already copied to annotations, no need to copy again.
Signed-off-by: jicheng.sk <jicheng.sk@alibaba-inc.com>
1b1abc9 to
4aeb1dc
Compare
Ⅰ. Describe what this PR does
For sandbox csi volume mount, the config should to be recorded in sandbox annotation.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews