update using sandbox spec runtimeconfig instend of annotation flag#239
Merged
furykerry merged 1 commit intoopenkruise:masterfrom Apr 1, 2026
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #239 +/- ##
==========================================
+ Coverage 65.26% 66.34% +1.07%
==========================================
Files 109 111 +2
Lines 7099 7386 +287
==========================================
+ Hits 4633 4900 +267
- Misses 2186 2201 +15
- Partials 280 285 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
furykerry
reviewed
Apr 1, 2026
| // Sandbox Manager or Sandbox Claim creates high-priority sandboxes by default. | ||
| SandboxAnnotationPriority = "agents.kruise.io/sandbox-priority" | ||
|
|
||
| // ShouldInjectCsiMount is the annotation key for inject csi mount plugin container. |
Member
There was a problem hiding this comment.
we should also add runtimes fields in sandboxset and sandboxtemplate
BH4AWS
force-pushed
the
feat/add_sandbox_spec_runtime_config
branch
from
150cfb6 to
7d462b0
Compare
furykerry
reviewed
Apr 1, 2026
Signed-off-by: jicheng.sk <jicheng.sk@alibaba-inc.com>
BH4AWS
force-pushed
the
feat/add_sandbox_spec_runtime_config
branch
from
7d462b0 to
ba90553
Compare
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews