Skip to content

sandbox claim support PauseTime#243

Open
CoodeRver wants to merge 1 commit intoopenkruise:masterfrom
CoodeRver:master
Open

sandbox claim support PauseTime#243
CoodeRver wants to merge 1 commit intoopenkruise:masterfrom
CoodeRver:master

Conversation

@CoodeRver
Copy link
Copy Markdown

Change-Id: Iaa4e20c6981074aef6ce6932fc0aa8c4ae4efe8f

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot
Copy link
Copy Markdown

Welcome @CoodeRver! It looks like this is your first PR to openkruise/agents 🎉

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.38%. Comparing base (6bb7d22) to head (fade933).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
+ Coverage   66.34%   66.38%   +0.04%     
==========================================
  Files         111      111              
  Lines        7386     7389       +3     
==========================================
+ Hits         4900     4905       +5     
+ Misses       2201     2200       -1     
+ Partials      285      284       -1     
Flag Coverage Δ
unittests 66.38% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

if claim.Spec.ShutdownTime != nil {
opts.ShutdownTime = claim.Spec.ShutdownTime.Time
}
if claim.Spec.PauseTime != nil {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add e2e for this case?

Change-Id: Ie509d168fb67b243e78d4f2486f5622398cec1d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants